[PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration

Parvathi Pudi parvathi at couthit.com
Wed May 7 05:56:01 PDT 2025


Hi,

> On 5/3/25 2:10 PM, Parvathi Pudi wrote:
>> +static int icssm_prueth_emac_config(struct prueth_emac *emac)
>> +{
>> +	struct prueth *prueth = emac->prueth;
>> +
>> +	/* PRU needs local shared RAM address for C28 */
>> +	u32 sharedramaddr = ICSS_LOCAL_SHARED_RAM;
>> +
>> +	/* PRU needs real global OCMC address for C30*/
>> +	u32 ocmcaddr = (u32)prueth->mem[PRUETH_MEM_OCMC].pa;
>> +	void __iomem *dram_base;
>> +	void __iomem *mac_addr;
>> +	void __iomem *dram;
> 
> Minor nit: please respect the reverse christmas tree order above.
> 
> /P

We will address this in the next version.


Thanks and Regards,
Parvathi.



More information about the linux-arm-kernel mailing list