[EXT] Re: [PATCH RFC] dmaengine: fsl-edma: Fix return code for unhandled interrupts

[Joy Zou]

> -----Original Message-----
> From: Stefan Wahren <wahrenst at gmx.net>
> Sent: 2025年5月6日 20:59
> To: Frank Li <frank.li at nxp.com>; Joy Zou <joy.zou at nxp.com>; Vinod Koul
> <vkoul at kernel.org>
> Cc: imx at lists.linux.dev; dmaengine at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org
> Subject: [EXT] Re: [PATCH RFC] dmaengine: fsl-edma: Fix return code for
> unhandled interrupts
> 
> 
> Hi Frank,
> hi Joy,
> 
> Am 24.04.25 um 13:48 schrieb Stefan Wahren:
> > For fsl,imx93-edma4 two DMA channels share the same interrupt.
> > So in case fsl_edma3_tx_handler is called for the "wrong"
> > channel, the return code must be IRQ_NONE. This signalize that the
> > interrupt wasn't handled.
> >
> > Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
> > Signed-off-by: Stefan Wahren <wahrenst at gmx.net>
> any comments on this?
> 
> Thanks
Reviewed-by: Joy Zou <joy.zou at nxp.com>
BR
Joy Zou
> > ---
> >
> > Hi,
> > this issue was found on a custom i.MX93 board. This patch has been
> > tested on the same platform.
> >
> >   drivers/dma/fsl-edma-main.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> > index 756d67325db5..66bfa28d984e 100644
> > --- a/drivers/dma/fsl-edma-main.c
> > +++ b/drivers/dma/fsl-edma-main.c
> > @@ -57,7 +57,7 @@ static irqreturn_t fsl_edma3_tx_handler(int irq,
> > void *dev_id)
> >
> >       intr = edma_readl_chreg(fsl_chan, ch_int);
> >       if (!intr)
> > -             return IRQ_HANDLED;
> > +             return IRQ_NONE;
> >
> >       edma_writel_chreg(fsl_chan, 1, ch_int);
> >