[PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data struct

[Lorenzo Bianconi]

> On Thu, 1 May 2025 22:47:06 +0200 Lorenzo Bianconi wrote:
> > On May 01, Jakub Kicinski wrote:
> > > On Tue, 29 Apr 2025 16:17:41 +0200 Lorenzo Bianconi wrote:  
> > > > Moreover, add __packed attribute to ppe_mbox_data struct definition and
> > > > make the fw layout padding explicit in init_info struct.  
> > > 
> > > Why? everything looks naturally packed now :(  
> > 
> > What I mean here is the padding in the ppe_mbox_data struct used by the fw running
> > on the NPU, not in the version used by the airoha_eth driver, got my point?
> > Sorry, re-reading it, it was not so clear, I agree.
> 
> You mean adding the "u8 rsv[3];" ? that is fine.
> I don't get why we also need to add the 3 __packed

I agree the __packed attributes are not mandatory at the moment, we just agreed
with Jacob that is fine to add them. Do you prefer to get rid of them?

Regards,
Lorenzo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250502/68740b1c/attachment.sig>