[PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data struct
Lorenzo Bianconi
lorenzo at kernel.org
Thu May 1 13:47:06 PDT 2025
On May 01, Jakub Kicinski wrote:
> On Tue, 29 Apr 2025 16:17:41 +0200 Lorenzo Bianconi wrote:
> > Moreover, add __packed attribute to ppe_mbox_data struct definition and
> > make the fw layout padding explicit in init_info struct.
>
> Why? everything looks naturally packed now :(
What I mean here is the padding in the ppe_mbox_data struct used by the fw running
on the NPU, not in the version used by the airoha_eth driver, got my point?
Sorry, re-reading it, it was not so clear, I agree.
Regards,
Lorenzo
> __packed also forces the compiler to assume the data is unaligned AFAIU.
> The recommended way to ensure the compiler doesn't insert padding is
> to do a compile time assert.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250501/073a3338/attachment.sig>
More information about the linux-arm-kernel
mailing list