[PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description

Krzysztof Kozlowski krzk at kernel.org
Sun Mar 30 02:47:32 PDT 2025


On 29/03/2025 23:10, Lukasz Majewski wrote:
>>> +  
>>
>> If this is ethernet switch, why it does not reference ethernet-switch
>> schema? or dsa.yaml or dsa/ethernet-ports? I am not sure which one
>> should go here, but surprising to see none.
> 
> It uses:
> $ref:·ethernet-controller.yaml#
> 
> for "ports".
> 
> Other crucial node is "mdio", which references $ref: mdio.yaml#

These are children, I am speaking about this device node.

> 
>>
>>> +properties:
>>> +  compatible:
>>> +    const: nxp,imx287-mtip--switch  
>>
>> Just one -.
>>
> 
> Ok.
> 
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +    description:
>>> +      The physical base address and size of the MTIP L2 SW module
>>> IO range  
>>
>> Wasn't here, drop.
>>
> 
> The 'reg' property (reg = <0x800f0000 0x20000>;) is defined in
> imx28.dtsi, where the SoC generic properties (as suggested by Andrew -
> like clocks, interrupts, clock-names) are moved.

Drop description, not the reg. Reg was in the previous version. You
added random changes here, not coming from the previous review.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list