[PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

[Krzysztof Kozlowski]

On 26/03/2025 14:43, Lukasz Majewski wrote:
> Hi Andrew,
> 
>>> +  phy-reset-gpios:
>>> +    deprecated: true
>>> +    description:
>>> +      Should specify the gpio for phy reset.  
>>
>> It seem odd that a new binding has deprecated properties. Maybe add a
>> comment in the commit message as to why they are there. I assume this
>> is because you are re-using part of the FEC code as is, and it
>> implements them?
>>
> 
> In the case of MTIP L2 switch, the reset gpio line (in my case, but
> also on e.g. imx28-evk, and vf610) is single for both PHYs.

That's kind of proof that property was not placed in correct place.

> 
> I could move the reset to mdio child nodes, but this would be
> problematic, as asserting reset on one PHY would reset the second one.

It wouldn't if you used reset controller framework for that GPIO. Please
move the GPIOs to the device actually having the line, so the GPIOs.

Since a year such workarounds are not allowed in kernel anymore.

Best regards,
Krzysztof