[PATCH v2] i2c: iproc: Refactor prototype and remove redundant error checks
Andi Shyti
andi.shyti at kernel.org
Thu Mar 20 14:29:20 PDT 2025
Hi Wentao,
...
> @@ -1169,9 +1165,7 @@ static int bcm_iproc_i2c_resume(struct device *dev)
> * Power domain could have been shut off completely in system deep
> * sleep, so re-initialize the block here
> */
> - ret = bcm_iproc_i2c_init(iproc_i2c);
> - if (ret)
> - return ret;
> + bcm_iproc_i2c_init(iproc_i2c);
This caused a:
warning: unused variable ‘ret’
Please, make sure next time to compile properly before submitting
patches. For now I fixed the warning and merged your patch to
i2c/i2c-hist.
Thanks,
Andi
>
> /* configure to the desired bus speed */
> val = iproc_i2c_rd_reg(iproc_i2c, TIM_CFG_OFFSET);
> --
> 2.42.0.windows.2
>
More information about the linux-arm-kernel
mailing list