[PATCH] nvmem: lpc18xx_eeprom: Convert to platform remove callback returning void
Vladimir Zapolskiy
vz at mleia.com
Sun Mar 16 07:39:45 PDT 2025
On 3/8/24 10:51, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Reviewed-by: Vladimir Zapolskiy <vz at mleia.com>
Thank you for the change!
--
Best wishes,
Vladimir
More information about the linux-arm-kernel
mailing list