[PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node

[Wilson Ding]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Friday, March 7, 2025 1:00 AM
> To: Wilson Ding <dingwei at marvell.com>; linux-kernel at vger.kernel.org;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> robh at kernel.org
> Cc: andrew at lunn.ch; gregory.clement at bootlin.com;
> sebastian.hesselbarth at gmail.com; krzk+dt at kernel.org; conor+dt at kernel.org;
> p.zabel at pengutronix.de; Sanghoon Lee <salee at marvell.com>;
> Geethasowjanya Akula <gakula at marvell.com>
> Subject: Re: [EXTERNAL] Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add
> reset controller node
> 
> On 06/03/2025 18:42, Wilson Ding wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk at kernel.org>
> >> Sent: Wednesday, March 5, 2025 11:29 PM
> >> To: Wilson Ding <dingwei at marvell.com>; linux-kernel at vger.kernel.org;
> >> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> >> robh at kernel.org
> >> Cc: andrew at lunn.ch; gregory.clement at bootlin.com;
> >> sebastian.hesselbarth at gmail.com; krzk+dt at kernel.org;
> >> conor+dt at kernel.org; p.zabel at pengutronix.de; Sanghoon Lee
> >> <salee at marvell.com>; Geethasowjanya Akula <gakula at marvell.com>
> >> Subject: [EXTERNAL] Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x:
> >> Add reset controller node
> >>
> >> On 04/03/2025 20:08, Wilson Ding wrote:
> >>>
> >>> I did consider shrinking the syscon's register address range to make
> >>> the reset-controller node to be independent from the syscon node.
> >>> However, I found the syscon node is also referred by some devices
> >>> for miscellaneous configurations . The reset configuration register
> >>> happens to be located in between these registers and clock/GPIO
> >>> registers.
> >>>
> >>>> drop offset in your patch or unify everything into 'reg'.
> >>>>
> >>>
> >>> This is exactly what I proposed in v3 patch. Do I misunderstand you?
> >>>
> >>> CP11X_LABEL(swrst): reset-controller at 268 {
> >>> 	compatible = "marvell,armada8k-reset";
> >>> 	reg = <0x268 0x4>;
> >>> 	#reset-cells = <1>;
> >>> };
> >>
> >> I don't see the other device being fixed here. How did you unify them?
> >
> > This patch series is about the proposal of Armada8K's reset controller
> > dt-binding. The dt-bindings issues of clock/GPIO controllers have been
> > there for years. Having to say, it is not just a simple patch to fix
> > it. It
> 
> 
> I understand, you just want to throw your patch here over the wall. It's
> reasonable, I feel it. Just like previous cases for this binding - everyone wanted
> one subnode at a time, ignoring bigger picture, each time making it franken-
> node or franken-binding.
> 
> Please listen to Greg's talk from years ago about upstreaming. "I don't want
> your code":
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.youtube.com_watch-3Fv-
> 3DfMeH7wqOwXA&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=sXDQZu4G
> yqNVDlFUXakSGJl0Dh81ZIPlU26YS4KHGIA&m=JlqowP3KS_dAuPARdfHNUE
> mdfiBr1kVd2ia1atnDNxBMMB5ccqNUuU1qtNhJMhzE&s=WpwrGxdqS7L0Bz-
> fKr_AdTuLBD2v-0OEKSRBOG05wKs&e=
> 

Sorry, I will fix them in next version.

> 
> Best regards,
> Krzysztof