[PATCH] pinctrl: meson: fix pin input property for a4
Xianwei Zhao via B4 Relay
devnull+xianwei.zhao.amlogic.com at kernel.org
Sun Mar 2 23:53:20 PST 2025
From: Xianwei Zhao <xianwei.zhao at amlogic.com>
The register of pin input attribute means the opposite.
value of reigster meaning is 1 for input and 0 for output.
So fix it.
Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Xianwei Zhao <xianwei.zhao at amlogic.com>
---
drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index a5218e8f1e03..35d5540b8eaa 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -775,7 +775,7 @@ static int aml_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio)
if (ret)
return ret;
- return BIT(bit) & val ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN;
+ return BIT(bit) & val ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT;
}
static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio)
@@ -785,7 +785,7 @@ static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio)
aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, ®, &bit);
- return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0);
+ return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit));
}
static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio,
@@ -796,7 +796,7 @@ static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio,
int ret;
aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, ®, &bit);
- ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit));
+ ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0);
if (ret < 0)
return ret;
---
base-commit: 73e4ffb27bb8a093d557bb2dac1a271474cca99c
change-id: 20250303-fix-a4-pinctl-4b215f3f9488
Best regards,
--
Xianwei Zhao <xianwei.zhao at amlogic.com>
More information about the linux-arm-kernel
mailing list