[PATCH v15 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller

Marc Zyngier maz at kernel.org
Sat Mar 1 04:02:09 PST 2025


On Thu, 20 Feb 2025 20:01:10 +0000,
Frank Li <Frank.li at nxp.com> wrote:
> 
> On Tue, Feb 11, 2025 at 02:21:53PM -0500, Frank Li wrote:
> 
> Thomas Gleixner and Marc Zyngier:
> 
> 	Do you have any comments about irq/msi part?

It certainly looks better and less invasive than the previous
incarnations. Things to fix:

- Documentation: the msi-map property usage is undefined outside of a
  PCIe RC, and the way you describe its use is so vague I read
  anything in it. Please update
  Documentation/devicetree/bindings/pci/pci-msi.txt to reflect the new
  use case.

- This IMMUTABLE thing serves no purpose, because you don't randomly
  plug this end-point block on any MSI controller. They come as part
  of an SoC.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list