[PATCH v3 18/28] of: property: Allow fw_devlink device-tree on x86 when PCI device-tree node creation is enabled

[Andy Shevchenko]

On Fri, Jun 27, 2025 at 11:22:45AM -0500, Rob Herring wrote:
> On Fri, Jun 13, 2025 at 03:47:58PM +0200, Herve Codina wrote:

...

> > -	if (IS_ENABLED(CONFIG_X86))
> > +	if (IS_ENABLED(CONFIG_X86) && !IS_ENABLED(CONFIG_PCI_DYNAMIC_OF_NODES))
> 
> I really want CONFIG_PCI_DYNAMIC_OF_NODES to go away at some point, not 
> add more users. 
> 
> I think this should instead check for specific platforms not with 
> kconfig symbols but DT properties. For ce4100, you can just check the 
> root compatible string. For OLPC, there isn't a root compatible (in the 
> DT I have). You could check for /architecture == OLPC instead. There's 
> some virtualization guests using DT now too. I would think their DT's 
> are simple enough to avoid any fw_devlink issues. 

I don't think this is good approach. The above check is more reliable in my
opinion.

> Alternatively, we could perhaps make x86 fw_devlink default off

For my (little) knowledge I believe this is not feasible anymore.
Some x86 code (drivers) relies on fw_devlink nowadays. But take
this with grain of salt, I may be way mistaken.

> and then enable it only when you create nodes. Maybe it has to be restricted
> a sub tree of the DT to avoid any later interactions if devices are unbound
> and rebound. Not a fully fleshed out idea...

-- 
With Best Regards,
Andy Shevchenko