[PATCH v4 01/10] coresight: tmc: Support atclk

[Leo Yan]

Hi Levi,

On Fri, Jun 27, 2025 at 02:49:19PM +0100, Yeoreum Yun wrote:
> >
> > > @@ -789,6 +789,10 @@ static int __tmc_probe(struct device *dev, struct resource *res)
> > >  	struct coresight_desc desc = { 0 };
> > >  	struct coresight_dev_list *dev_list = NULL;
> > >
> > > +	drvdata->atclk = devm_clk_get_optional_enabled(dev, "atclk");
> > > +	if (IS_ERR(drvdata->atclk))
> > > +		return PTR_ERR(drvdata->atclk);
> > > +
> > >  	ret = -ENOMEM;
> > >
> >
> > Just another quetion.
> >
> > If this function is called from tmc_platform_probe() and failed,
> > should it call the clk_put() for drvdata->pclk when it failed?
> 
> Sorry, I missed the Patch #7.

No worries.

devm_clk_release() is a registered callback used by the device model
layer to release resources. The clock will be released in the flow:

  devm_clk_release()
    `> clk_put()
         `> free_clk()

Thanks,
Leo