[PATCH v4 01/10] coresight: tmc: Support atclk

Yeoreum Yun yeoreum.yun at arm.com
Fri Jun 27 06:27:48 PDT 2025


Hi Leo,

[...]

> @@ -789,6 +789,10 @@ static int __tmc_probe(struct device *dev, struct resource *res)
>  	struct coresight_desc desc = { 0 };
>  	struct coresight_dev_list *dev_list = NULL;
>
> +	drvdata->atclk = devm_clk_get_optional_enabled(dev, "atclk");
> +	if (IS_ERR(drvdata->atclk))
> +		return PTR_ERR(drvdata->atclk);
> +
>  	ret = -ENOMEM;
>

Just another quetion.

If this function is called from tmc_platform_probe() and failed,
should it call the clk_put() for drvdata->pclk when it failed?

--
Sincerely,
Yeoreum Yun



More information about the linux-arm-kernel mailing list