[PATCH 06/13] perf: stm32: introduce DDRPERFM driver
Clement LE GOFFIC
clement.legoffic at foss.st.com
Tue Jun 24 03:43:08 PDT 2025
On 6/23/25 11:45, Krzysztof Kozlowski wrote:
[...]
Hi Krzysztof,
Sorry I forgot to address comments below.
>> +
>> +static const struct stm32_ddr_pmu_cfg stm32_ddr_pmu_cfg_mp1 = {
>> + .regs = &stm32_ddr_pmu_regspec_mp1,
>> + .attribute = stm32_ddr_pmu_attr_groups_mp1,
>> + .counters_nb = MP1_CNT_NB,
>> + .evt_counters_nb = MP1_CNT_NB - 1, /* Time counter is not an event counter */
>> + .time_cnt_idx = MP1_TIME_CNT_IDX,
>> + .get_counter = stm32_ddr_pmu_get_event_counter_mp1,
>> +};
>> +
>> +static const struct stm32_ddr_pmu_cfg stm32_ddr_pmu_cfg_mp2 = {
>> + .regs = &stm32_ddr_pmu_regspec_mp2,
>> + .attribute = stm32_ddr_pmu_attr_groups_mp2,
>> + .counters_nb = MP2_CNT_NB,
>> + .evt_counters_nb = MP2_CNT_NB - 1, /* Time counter is an event counter */
>> + .time_cnt_idx = MP2_TIME_CNT_IDX,
>> + .get_counter = stm32_ddr_pmu_get_event_counter_mp2,
>> +};
>> +
>> +static const struct dev_pm_ops stm32_ddr_pmu_pm_ops = {
>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, stm32_ddr_pmu_device_resume)
>> +};
>> +
>> +static const struct of_device_id stm32_ddr_pmu_of_match[] = {
>> + {
>> + .compatible = "st,stm32mp131-ddr-pmu",
>> + .data = &stm32_ddr_pmu_cfg_mp1
>> + },
>> + {
>> + .compatible = "st,stm32mp151-ddr-pmu",
>> + .data = &stm32_ddr_pmu_cfg_mp1
>
> So devices are compatible, thus express it correctly and drop this.
Ok so I assume this comes with your comment in the bindings and
basically don't get you point here.
Can you please be more precise ?
>
>> + },
>> + {
>> + .compatible = "st,stm32mp251-ddr-pmu",
>> + .data = &stm32_ddr_pmu_cfg_mp2
>> + },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, stm32_ddr_pmu_of_match);
>> +
>> +static struct platform_driver stm32_ddr_pmu_driver = {
>> + .driver = {
>> + .name = DRIVER_NAME,
>> + .pm = &stm32_ddr_pmu_pm_ops,
>> + .of_match_table = of_match_ptr(stm32_ddr_pmu_of_match),
>
> Drop of_match_ptr, you have here warnings.
Yes Indeed.
I'll also fix the pm pointer by using "pm_sleep_ptr".
Best regards,
Clément
>
>
>
> Best regards,
> Krzysztof
More information about the linux-arm-kernel
mailing list