[PATCH 0/2] ACPI: Improve SPCR handling and messaging on SPCR-less systems
Hanjun Guo
guohanjun at huawei.com
Thu Jun 19 07:42:29 PDT 2025
Hi Li Chen,
On 2025/6/6 15:27, Li Chen wrote:
> From: Li Chen <chenl311 at chinatelecom.cn>
>
> This small series improves the kernel behavior and output when the ACPI SPCR
> table is not present or not supported.
>
> Currently, even on systems that completely lack an SPCR table, the kernel prints:
> "Use ACPI SPCR as default console: Yes"
Agreed, this is wrong, we need to fix it.
>
> Or if with acpi=nospcr:
> "Use ACPI SPCR as default console: No"
I think this is OK, it's just to let you know we are not
using ACPI SPCR console when ACPI is enabled, including
cases with no SPCR table.
>
> This may mislead users into thinking an SPCR table exists
> when in fact there is no such table at all. This series addresses this in two steps:
>
> Patch 1 ensures that acpi_parse_spcr() returns -ENODEV if CONFIG_ACPI_SPCR_TABLE is disabled.
>
> Patch 2 updates arm64 acpi_boot_table_init() to only print the SPCR console message
> if acpi_parse_spcr() succeeds.
I have some detail comments for patch 2.
Thanks
Hanjun
More information about the linux-arm-kernel
mailing list