[PATCH v3 0/9] initial usbdrd phy support for Exynosautov920 soc
Pritam Manohar Sutar
pritam.sutar at samsung.com
Tue Jun 17 11:20:32 PDT 2025
Hi Rob,
> -----Original Message-----
> From: Rob Herring (Arm) <robh at kernel.org>
> Sent: 17 June 2025 03:17 AM
> To: Pritam Manohar Sutar <pritam.sutar at samsung.com>
> Cc: rosa.pila at samsung.com; s.nawrocki at samsung.com; linux-samsung-
> soc at vger.kernel.org; conor+dt at kernel.org; linux-kernel at vger.kernel.org;
> andre.draszik at linaro.org; linux-phy at lists.infradead.org; vkoul at kernel.org;
> krzk+dt at kernel.org; faraz.ata at samsung.com; selvarasu.g at samsung.com;
> kauschluss at disroot.org; ivo.ivanov.ivanov1 at gmail.com;
> dev.tailor at samsung.com; devicetree at vger.kernel.org; kishon at kernel.org;
> peter.griffin at linaro.org; muhammed.ali at samsung.com; linux-arm-
> kernel at lists.infradead.org; alim.akhtar at samsung.com;
> m.szyprowski at samsung.com
> Subject: Re: [PATCH v3 0/9] initial usbdrd phy support for Exynosautov920
> soc
>
>
> On Fri, 13 Jun 2025 11:26:04 +0530, Pritam Manohar Sutar wrote:
> > This SoC has a single USB 3.1 DRD combo phy and three USB2.0 only DRD
> > phy controllers
> >
> > - Combo phy supports USB3.1 SSP+(10Gbps) protocol and is backwards
> > compatible to the USB3.0 SS(5Gbps). 'Add-on USB2.0' phy is added
> > to support USB2.0 HS(480Mbps), FS(12Mbps) and LS(1.5Mbps) data
> > rates. These two phys are combined to form a combo phy as mentioned
> > below.
> >
> > USB30DRD_0 port
> >
> > +-----------------------------------------------------+
> > | |
> > | (combo) USB PHY controller |
> > | +-----------------------------------------+ |
> > | | USB HSPHY | |
> > | | (samsung,exynosautov920-usbdrd-hsphy) | |
> > | +-----------------------------------------+ |
> > | |
> > | +---------------------------------------------+ |
> > | | USB SSPHY | |
> > | | (samsung,exynosautov920-usb31drd-ssphy) | |
> > | +---------------------------------------------+ |
> > | |
> > +-----------------------------------------------------+
> > | |
> > | USBDRD30 Link |
> > | Controller |
> > | |
> > +-----------------------------------------------------+
> >
> > - USB2.0 phy supports only UTMI+ interface. USB2.0DRD phy
> > is very similar to the existing Exynos850 support in this driver.
> >
> > USB20DRD_0/1/2 ports
> >
> >
> > +---------------------------------------------------+
> > | |
> > | USB PHY controller |
> > | +-----------------------------------------+ |
> > | | USB HSPHY | |
> > | | (samsung,exynosautov920-usbdrd-phy) | |
> > | +-----------------------------------------+ |
> > | |
> > +---------------------------------------------------+
> > | |
> > | USBDRD20_* Link |
> > | Controller |
> > | |
> > +---------------------------------------------------+
> >
> > This patchset only supports device mode and same is verified with as
> > NCM device with below configfs commands
> >
> > changelog
> > ----------
> > Changes in v2:
> > - Used standard GENMASK() and FIELD_GET() to get the major version
> > from controller version register.
> > link for v1:
> > https://lore.kernel.org/linux-phy/20250514134813.380807-1-pritam.sutar
> > @samsung.com/
> >
> > Changes in v3:
> > - Updated dt-bindings for USB2.0 only.
> > - Added dt-bindings for combo phy.
> > - Added implementation for combo phy (SS and HS phy).
> > - Added added DTS nodes for all the phys.
> > link for v2:
> > https://lore.kernel.org/linux-phy/20250516102650.2144487-1-pritam.suta
> > r at samsung.com/
> >
> > Pritam Manohar Sutar (9):
> > dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy
> > compatible
> > phy: exyons5-usbdrd: support HS phy for ExynosAutov920
> > arm64: dts: exynos: ExynosAutov920: add USB and USB-phy nodes
> > dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo HS
> > phy
> > phy: exyons5-usbdrd: support HS combo phy for ExynosAutov920
> > arm64: dts: exynos: ExynosAutov920: add USB and USB HS combo phy
> nodes
> > dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo SS
> > phy
> > phy: exyons5-usbdrd: support SS combo phy for ExynosAutov920
> > arm64: dts: exynos: ExynosAutov920: add USB and USB SS combo phy
> > nodes
> >
> > .../bindings/phy/samsung,usb3-drd-phy.yaml | 6 +
> > .../boot/dts/exynos/exynosautov920-sadk.dts | 53 ++
> > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 155 +++++
> > drivers/phy/samsung/phy-exynos5-usbdrd.c | 529
> ++++++++++++++++++
> > 4 files changed, 743 insertions(+)
> >
> > --
> > 2.34.1
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform maintainer
> whether these warnings are acceptable or not. No need to reply unless the
> platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then make sure dt-
> schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: attempting to guess base-commit...
> Base: tags/v6.16-rc1-6-g8a22d9e79cf0 (exact match)
>
> If this is not the correct base, please add 'base-commit' tag (or use b4 which
> does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for
> arch/arm64/boot/dts/exynos/' for 20250613055613.866909-1-
> pritam.sutar at samsung.com:
>
> arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb at 16600000
> (samsung,exynosautov920-dwusb3): 'vdd33-supply' is a required property
> from schema $id: https://protect2.fireeye.com/v1/url?k=a398ebb0-
> c213fe83-a39960ff-000babff9bb7-8d9cc7c90d9462da&q=1&e=59f25a9c-244f-
> 45e8-a7cb-
> 211aa2722987&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fsa
> msung%2Cexynos-dwc3.yaml%23
> arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb at 16700000
> (samsung,exynosautov920-dwusb3): 'vdd33-supply' is a required property
> from schema $id: https://protect2.fireeye.com/v1/url?k=c803d102-
> a988c431-c8025a4d-000babff9bb7-2f005fe0951204df&q=1&e=59f25a9c-244f-
> 45e8-a7cb-
> 211aa2722987&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fsa
> msung%2Cexynos-dwc3.yaml%23
> arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb at 16800000
> (samsung,exynosautov920-dwusb3): 'vdd33-supply' is a required property
> from schema $id: https://protect2.fireeye.com/v1/url?k=1f0616ff-
> 7e8d03cc-1f079db0-000babff9bb7-3473467f8f5ba11c&q=1&e=59f25a9c-244f-
> 45e8-a7cb-
> 211aa2722987&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fsa
> msung%2Cexynos-dwc3.yaml%23
> arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: usb at 16900000
> (samsung,exynosautov920-dwusb3): 'vdd33-supply' is a required property
> from schema $id: https://protect2.fireeye.com/v1/url?k=989abcf3-
> f911a9c0-989b37bc-000babff9bb7-7f2e26e2d23d90b1&q=1&e=59f25a9c-
> 244f-45e8-a7cb-
> 211aa2722987&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fsa
> msung%2Cexynos-dwc3.yaml%23
>
>
>
>
LDO regulators are always on. USB don’t control them for ExynosAutov920. Hence vdd33-supply is omitted from dts.
Will try to add dummy regulator to add required field and patch will be updated in next version of the patch-set (v4)
Thank you,
Regards,
Pritam
More information about the linux-arm-kernel
mailing list