[PATCH v3 1/9] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
Pritam Manohar Sutar
pritam.sutar at samsung.com
Tue Jun 17 10:52:36 PDT 2025
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 16 June 2025 01:45 PM
> To: Pritam Manohar Sutar <pritam.sutar at samsung.com>
> Cc: vkoul at kernel.org; kishon at kernel.org; robh at kernel.org;
> krzk+dt at kernel.org; conor+dt at kernel.org; alim.akhtar at samsung.com;
> andre.draszik at linaro.org; peter.griffin at linaro.org; kauschluss at disroot.org;
> ivo.ivanov.ivanov1 at gmail.com; m.szyprowski at samsung.com;
> s.nawrocki at samsung.com; linux-phy at lists.infradead.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.org;
> rosa.pila at samsung.com; dev.tailor at samsung.com;
> faraz.ata at samsung.com; muhammed.ali at samsung.com;
> selvarasu.g at samsung.com
> Subject: Re: [PATCH v3 1/9] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
>
> On Fri, Jun 13, 2025 at 11:26:05AM GMT, Pritam Manohar Sutar wrote:
> > Add a dedicated compatible string for USB HS phy found in this SoC.
>
> You add HS phy in other commit/patch. This is just confusing.
>
> > The devicetree node requires two clocks, named "phy" and "ref"
>
> No. Explain the hardware, not the DTS. How many clocks, supplies etc
> hardware has.
>
ok will change commit message accordingly in next version of the patch-set.
> Best regards,
> Krzysztof
Thank you.
Regards,
Pritam
More information about the linux-arm-kernel
mailing list