[PATCH v2 00/17] SHA-512 library functions
Eric Biggers
ebiggers at kernel.org
Mon Jun 16 23:05:23 PDT 2025
On Sun, Jun 15, 2025 at 06:40:02PM -0700, Eric Biggers wrote:
> - Tests are KUnit tests, and they are fairly thorough (more thorough
> than crypto/testmgr.c) and also optionally include benchmarks.
An additional note on testing: I have scripts that build the kernel for all the
arches that have arch-specific code in lib/crc/ or lib/crypto/, launch them in
QEMU with various -cpu options, and gather the results of the tests and any
other issues like warns or panics.
I'll get it into a sharable form at some point.
As far as the coverage of the arch-specific code in this specific patchset goes,
I've verified that my testing strategy covers all sha512_blocks() code paths,
including fallbacks, on arm, arm64, s390, riscv, and x86.
The two incomplete ones are mips and sparc, where I cannot test their optimized
code paths in sha512_blocks() because QEMU does not support it.
Still, I don't expect any issues. That code is ultimately doing the same thing
as it was before for SHA-512 block processing, just integrated in a simpler way.
FWIW, my policy going forward is that any new arch-specific code in lib/crc/ or
lib/crypto/ *MUST* come with QEMU support so that it can be tested. It's only
migration of existing code (usually from arch/*/crypto/) like this where I may
tolerate not being able to test it; that code gets "grandfathered in"...
- Eric
More information about the linux-arm-kernel
mailing list