[PATCH v2] arm: orion5x: use string choices helper

Andy Shevchenko andy.shevchenko at gmail.com
Mon Jun 16 23:14:10 PDT 2025


On Tue, Jun 17, 2025 at 5:22 AM Kuninori Morimoto
<kuninori.morimoto.gx at renesas.com> wrote:
>
> It updates format to keep "online/offline".
>
> -       sprintf(buf, "%s\n",     ...? "online" : "offline");
> +       sprintf(buf, "%sline\n", ..., str_on_off(...));
>                         ^^^^

With all the respect to Andrew and his review, this is still NAK, but
now from me. Add the respective helper to the string_choices.h, the
proposed change is harder to read and it makes things confusing.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list