[PATCH v5 3/9] arm64: dts: freescale: rename imx93.dtsi to imx91_93_common.dtsi

[Joy Zou]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 2025年6月13日 18:43
> To: Joy Zou <joy.zou at nxp.com>; robh at kernel.org; krzk+dt at kernel.org;
> conor+dt at kernel.org; shawnguo at kernel.org; s.hauer at pengutronix.de;
> catalin.marinas at arm.com; will at kernel.org; andrew+netdev at lunn.ch;
> davem at davemloft.net; edumazet at google.com; kuba at kernel.org;
> pabeni at redhat.com; mcoquelin.stm32 at gmail.com;
> alexandre.torgue at foss.st.com; ulf.hansson at linaro.org;
> richardcochran at gmail.com; kernel at pengutronix.de; festevam at gmail.com
> Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org;
> imx at lists.linux.dev; linux-arm-kernel at lists.infradead.org;
> netdev at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com;
> linux-pm at vger.kernel.org; Frank Li <frank.li at nxp.com>; Ye Li <ye.li at nxp.com>;
> Jacky Bai <ping.bai at nxp.com>; Peng Fan <peng.fan at nxp.com>; Aisheng Dong
> <aisheng.dong at nxp.com>; Clark Wang <xiaoning.wang at nxp.com>
> Subject: Re: [PATCH v5 3/9] arm64: dts: freescale: rename imx93.dtsi to
> imx91_93_common.dtsi
> 
> On 13/06/2025 12:02, Joy Zou wrote:
> > Rename imx93.dtsi to imx91_93_common.dtsi for adding imx91.dtsi.
> 
> Why?
Thanks for your comments!
The design of i.MX91 platform is very similar to i.MX93 and only some small differences.
The imx91.dtsi include the imx93.dtsi, each add to imx93.dtsi requires an remove
in imx91.dtsi for this unique to i.MX93, e.g. NPU. 
The imx91 isn't the imx93 subset, if the imx93.dtsi include the imx91.dtsi,
the same problem will occur.
Common + delta is better than commn - delta, so add common.dtsi for imx91 and imx93,
then the imx93 and imx91 will include the common.dtsi.
> 
> Your commit msg MUST explain that. That's the more important part.
Will modify commit message to explain that.  
> 
> > There is no code change.
> >
> > Add imx93.dtsi, which include imx91_93_common.dtsi.
> >
> > Signed-off-by: Joy Zou <joy.zou at nxp.com>
> > ---
> >  .../boot/dts/freescale/imx91_93_common.dtsi   | 1351
> +++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx93.dtsi      | 1349 +---------------
> 
> Generate patches with proper -M/-B/-C flags so it will be possible to actually
> review this.
Will add the proper -M/-B/-C flags when generate patches. 
Have tried do it and it's better!
> 
> 
> >  2 files changed, 1353 insertions(+), 1347 deletions(-)  create mode
> > 100644 arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > new file mode 100644
> > index 000000000000..64cd0776b43d
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > @@ -0,0 +1,1351 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright 2022 NXP
> > + */
> > +
> > +#include <dt-bindings/clock/imx93-clock.h> #include
> > +<dt-bindings/dma/fsl-edma.h> #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h> #include
> > +<dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/fsl,imx93-power.h>
> > +#include <dt-bindings/thermal/thermal.h>
> > +
> > +#include "imx93-pinfunc.h"
> > +
> > +/ {
> > +     interrupt-parent = <&gic>;
> > +     #address-cells = <2>;
> > +     #size-cells = <2>;
> > +
> > +     aliases {
> > +             gpio0 = &gpio1;
> > +             gpio1 = &gpio2;
> > +             gpio2 = &gpio3;
> > +             gpio3 = &gpio4;
> > +             i2c0 = &lpi2c1;
> > +             i2c1 = &lpi2c2;
> > +             i2c2 = &lpi2c3;
> > +             i2c3 = &lpi2c4;
> > +             i2c4 = &lpi2c5;
> > +             i2c5 = &lpi2c6;
> > +             i2c6 = &lpi2c7;
> > +             i2c7 = &lpi2c8;
> 
> Not common aliases. Drop.
Will drop these and add part to board dts for the convenience of customers. 
> 
> 
> > +             mmc0 = &usdhc1;
> > +             mmc1 = &usdhc2;
> > +             mmc2 = &usdhc3;
> 
> Not common aliases. Drop.
Will drop these and add part to board dts for the convenience of customers.
> 
> 
> > +             serial0 = &lpuart1;
> > +             serial1 = &lpuart2;
> > +             serial2 = &lpuart3;
> > +             serial3 = &lpuart4;
> > +             serial4 = &lpuart5;
> > +             serial5 = &lpuart6;
> > +             serial6 = &lpuart7;
> > +             serial7 = &lpuart8;
> 
> Not common aliases. Drop.
Will drop these and add part to board dts for the convenience of customers.
> 
> > +             spi0 = &lpspi1;
> > +             spi1 = &lpspi2;
> > +             spi2 = &lpspi3;
> > +             spi3 = &lpspi4;
> > +             spi4 = &lpspi5;
> > +             spi5 = &lpspi6;
> > +             spi6 = &lpspi7;
> > +             spi7 = &lpspi8;
> 
> Not common aliases. Drop.
Will drop these. 
BR
Joy Zou
> 
> 
> Best regards,
> Krzysztof