[PATCH v4 0/5] Add FIELD_MODIFY() helper
Luo Jie
quic_luoj at quicinc.com
Mon Jun 16 03:06:36 PDT 2025
On 6/12/2025 10:11 PM, Marc Zyngier wrote:
> On Thu, 12 Jun 2025 14:46:07 +0100,
> Luo Jie <quic_luoj at quicinc.com> wrote:
>>
>> Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield
>> macros. It is functionally similar as xxx_replace_bits(), but adds
>> the compile time checking to catch incorrect parameter type errors.
>>
>> This series also converts the four instances of opencoded FIELD_MODIFY()
>> that are found in the core kernel files, to instead use the new
>> FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding
>> the script field_modify.cocci.
>>
>> The changes are validated on IPQ9574 SoC which uses ARM64 architecture.
>>
>> Signed-off-by: Luo Jie <quic_luoj at quicinc.com>
>
> I already indicated that the *pre-existing* set of helpers are enough
> for what we want to do, that we *already* use them for KVM/arm64, and
> that I didn't need nor want two ways to do the same thing in the same
> code base.
>
> My opinion hasn't changed on that front, and I don't see a point in
> these patches.
>
> M.
>
OK. I will drop the ARM64 patches and only keep the coccinelle script
patch in the next version.
More information about the linux-arm-kernel
mailing list