[PATCH v2 2/2] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property

Michal Simek michal.simek at amd.com
Sun Jun 15 23:51:49 PDT 2025


Hi,

On 6/16/25 08:41, Krzysztof Kozlowski wrote:
> On 13/06/2025 13:26, Michal Simek wrote:
>>>> Based on discussion at
>>>> https://lore.kernel.org/lkml/20241002-revivable-crummy-f780adec538c@spud/
>>>>
>>>> Actually this shouldn't be only targetting GPIO but also for example
>>>> xlnx,xps-timebase-wdt-1.00.a but I would like to check it first on gpio
>>>> before starting to check other bindings.
>>>
>>> IIUC, patch #1 is a prerequisite, so you need to squash them. Otherwise
>>> dt_binding_check is not bisectable and we want it to be bisectable.
>>
>> No issue with squash if necessary. I sent it as series to be applied together
>> which won't break bisectability of tree and no new error is going to be reported.
> 
> You did not say anything about dependencies and merging strategy, to
> this would go via different trees. Sending something in one patchset
> does not mean that there is a dependency.

No offense but I don't think I can agree with this. The main purpose of patchset 
is to show sequence how things should go one after each other and series should 
go via single tree.
Sometimes people are asking for picking up individual patches from series but 
this is not a normal way. Also seen a lot of time asking for splitting that 
patches and send them individually instead of picking up from the series.

Anyway. If you want to me to squash it together I am fine with it.
If you want to me to create cover letter that's fine for me too.

Thanks,
Michal



More information about the linux-arm-kernel mailing list