[PATCH] usb: ohci-at91: Use dynamic device name for OHCI HCD creation

Alan Stern stern at rowland.harvard.edu
Thu Jun 12 09:32:38 PDT 2025


On Thu, Jun 12, 2025 at 10:33:09AM +0000, Mihai.Sain at microchip.com wrote:
> Hi Alan,
> 
> I'm sorry, I'm replying using Outlook web.
> 
> On Wed, Jun 11, 2025 at 10:54:15AM +0300, Mihai Sain wrote:
> > Use the dynamic device name instead of the hardcoded string "at91"
> > when creating the OHCI host controller driver.
> > This ensures that the device name is more flexible
> > and correctly reflects the actual device in the system.
> > This will be in sync with ehci at91 driver.
> >
> > [root at sam9x75eb ~]$ dmesg | grep usb
> > [    1.464487] usb usb1: Manufacturer: Linux 6.16.0-rc1 ehci_hcd
> > [    1.470210] usb usb1: SerialNumber: 700000.usb-ehci
> > [    1.595683] usb usb2: Manufacturer: Linux 6.16.0-rc1 ohci_hcd
> > [    1.601406] usb usb2: SerialNumber: 600000.usb-ohci
> >
> > [root at sam9x75eb ~]$ cat /proc/iomem | grep usb
> > 00600000-006fffff : 600000.usb-ohci usb-ohci at 600000
> > 00700000-007fffff : 700000.usb-ehci usb-ehci at 700000
> 
> Are these two outputs supposed to make some sort of point?  It would be
> better to have a before-and-after comparison, so we can see what the
> effect of the patch is.
> 
> Before this patch the SerialNumber print from ohci driver, was looking like this:
> 
> [    1.601406] usb usb2: SerialNumber: at91
> 
> I thought it was a good ideea to align this print with the one from ehci drive
Okay, good.  Yes, that is worth doing.

Please include this information in the patch description and resubmit.

Alan Stern



More information about the linux-arm-kernel mailing list