[PATCH v3 02/62] KVM: arm64: WARN if unmapping vLPI fails
Sean Christopherson
seanjc at google.com
Wed Jun 11 15:45:05 PDT 2025
WARN if unmapping a vLPI in kvm_vgic_v4_unset_forwarding() fails, as
failure means an IRTE has likely been left in a bad state, i.e. IRQs
won't go where they should. WARNing in arch code will eventually allow
dropping all the plumbing a similar WARN in kvm_irq_routing_update(),
and thus avoid having to plumb back a return code just to WARN.
Signed-off-by: Sean Christopherson <seanjc at google.com>
---
arch/arm64/kvm/vgic/vgic-v4.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kvm/vgic/vgic-v4.c b/arch/arm64/kvm/vgic/vgic-v4.c
index 193946108192..86e54cefc237 100644
--- a/arch/arm64/kvm/vgic/vgic-v4.c
+++ b/arch/arm64/kvm/vgic/vgic-v4.c
@@ -546,6 +546,7 @@ int kvm_vgic_v4_unset_forwarding(struct kvm *kvm, int host_irq)
atomic_dec(&irq->target_vcpu->arch.vgic_cpu.vgic_v3.its_vpe.vlpi_count);
irq->hw = false;
ret = its_unmap_vlpi(host_irq);
+ WARN_ON_ONCE(ret);
}
raw_spin_unlock_irqrestore(&irq->irq_lock, flags);
--
2.50.0.rc1.591.g9c95f17f64-goog
More information about the linux-arm-kernel
mailing list