Aw: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac

[Frank Wunderlich]

Hi

> Gesendet: Mittwoch, 11. Juni 2025 um 11:33
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>
> Betreff: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
>
> Il 08/06/25 23:14, Frank Wunderlich ha scritto:
> > From: Frank Wunderlich <frank-w at public-files.de>
> > 
> > Add SFP cages to Bananapi-R4 board. The 2.5g phy variant only contains the
> > wan-SFP, so add this to common dtsi and the lan-sfp only to the dual-SFP
> > variant.
> > 
> > Signed-off-by: Daniel Golle <daniel at makrotopia.org>
> > Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> > ---
> > v3:
> > - enable mac with 2.5g phy on r4 phy variant because driver is now mainline
> > ---
> >   .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts   | 12 ++++++++++++
> >   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts   | 18 ++++++++++++++++++
> >   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi  | 18 ++++++++++++++++++
> >   3 files changed, 48 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > index 53de9c113f60..e63e17ae35a0 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > @@ -9,3 +9,15 @@ / {
> >   	model = "Banana Pi BPI-R4 (1x SFP+, 1x 2.5GbE)";
> >   	chassis-type = "embedded";
> >   };
> > +
> > +&gmac1 {
> 
> phy = ...
> phy-c..onnection-type
> phy-m...ode

phy-connection-type is dropped in next version due to comment from andrew, but i order alphabetically

> > +	phy-mode = "internal";
> > +	phy-connection-type = "internal";
> > +	phy = <&int_2p5g_phy>;
> > +	status = "okay";
> > +};
> > +
> > +&int_2p5g_phy {
> > +	pinctrl-names = "i2p5gbe-led";
> > +	pinctrl-0 = <&i2p5gbe_led0_pins>;
> 
> pinctrl-names
> pinctrl-0

what the difference? i don't see it :(

the others i change in v4

regards Frank