[PATCH 2/8] media: imx-mipi-csis: Fix field alignment in register dump

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jun 10 00:47:39 PDT 2025


On Tue, Jun 10, 2025 at 09:12:26AM +0200, Alexander Stein wrote:
> Am Montag, 9. Juni 2025, 01:58:34 CEST schrieb Laurent Pinchart:
> > Commit 95a1379004cb ("media: staging: media: imx: imx7-mipi-csis: Dump
> > MIPI_CSIS_FRAME_COUNTER_CH0 register") forgot to increase the maximum
> > register name length, resulting in misalignment of names printed in the
> > kernel log. Fix it.
> 
> Does this warrant a Fixes tag? Anyway

I would then have to Cc stable as per the media subsystem rules, and I
really don't think this patch warrants being backported to stable
kernels.

> Reviewed-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  drivers/media/platform/nxp/imx-mipi-csis.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
> > index d59666ef7545..b652d59851c2 100644
> > --- a/drivers/media/platform/nxp/imx-mipi-csis.c
> > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c
> > @@ -895,7 +895,7 @@ static int mipi_csis_dump_regs(struct mipi_csis_device *csis)
> >  
> >  	for (i = 0; i < ARRAY_SIZE(registers); i++) {
> >  		cfg = mipi_csis_read(csis, registers[i].offset);
> > -		dev_info(csis->dev, "%14s: 0x%08x\n", registers[i].name, cfg);
> > +		dev_info(csis->dev, "%17s: 0x%08x\n", registers[i].name, cfg);
> >  	}
> >  
> >  	pm_runtime_put(csis->dev);

-- 
Regards,

Laurent Pinchart



More information about the linux-arm-kernel mailing list