[PATCH v3 0/3] Fix interrupt log message
Shawn Lin
shawn.lin at rock-chips.com
Mon Jun 9 02:14:58 PDT 2025
在 2025/06/08 星期日 0:01, Hans Zhang 写道:
> Dear Maintainers,
>
> Detailed descriptions of interrupts can be seen from RK3399 TRM doc.
> I found two errors and cleaned up the driver by the way.
>
> This patch series improves the logging accuracy and code cleanliness of
> the Rockchip PCIe host controller driver:
>
> Log Message Clarifications
>
> Patch 1 fixes a misleading debug message for the PCIE_CORE_INT_UCR
> interrupt, replacing a duplicated "malformed TLP" message with "Unexpected
> Completion" to reflect the actual error condition.
>
> Patch 2 corrects the terminology for non-fatal errors, renaming "no fatal
> error" to "non fatal error interrupt received" to align with PCIe interrupt
> semantics.
>
> Code Cleanup
>
> Patch 3 removes redundant header includes (e.g., unused clock/reset
> headers) to streamline the driver and reduce build dependencies.
>
> These changes enhance debug log reliability, eliminate ambiguity for
> developers.
>
Thanks for your patches.
Acked-by: Shawn Lin <shawn.lin at rock-chips.com>
> ---
> Changes for v3:
> - Add Reviewed-by: Manivannan Sadhasivam <mani at kernel.org> (Mani's new email address.)
>
> Changes for v2:
> - Drop patch [v1 3/4].
> - The other patches have not been modified.
> ---
>
> Hans Zhang (3):
> PCI: rockchip-host: Fix "Unexpected Completion" log message
> PCI: rockchip-host: Correct non-fatal error log message
> PCI: rockchip-host: Remove unused header includes
>
> drivers/pci/controller/pcie-rockchip-host.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
>
> base-commit: ec7714e4947909190ffb3041a03311a975350fe0
>
More information about the linux-arm-kernel
mailing list