[v3 PATCH 2/2] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Peng Fan <peng.fan at oss.nxp.com>
> Sent: Thursday, June 5, 2025 10:42 AM
> To: Frank Li <Frank.li at nxp.com>
> Cc: Li, Meng <Meng.Li at windriver.com>; linux at roeck-us.net;
> s.hauer at pengutronix.de; kernel at pengutronix.de; linux-
> watchdog at vger.kernel.org; imx at lists.linux.dev; shawnguo at kernel.org;
> robh at kernel.org; conor+dt at kernel.org; linux-arm-kernel at lists.infradead.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: Re: [v3 PATCH 2/2] arch: arm64: dts: add big-endian property back
> into watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Tue, Jun 03, 2025 at 10:55:01AM -0400, Frank Li wrote:
> >On Tue, Jun 03, 2025 at 12:02:30PM +0800, Meng Li wrote:
> >> When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> >> work. Because in commit 7c8ffc5555cb("arm64: dts: layerscape:
> >
> >Watchdog doesn't work on NXP ls1046ardb board because ...
> >
> >please wrap at 75 chas.
> >> remove big-endian for mmc nodes"), it intented to remove the
> >> big-endian from mmc node, but the big-endian of watchdog node is also
> >> removed by accident. So, add watchdog big-endian property back.
> >
> >extra empty line here.
> >
> >> In addition, fsl,ls1046a-wdt allows big-endian property, so add it
> >> into compatible property.
> >
> >In addition, add compatible string fsl,ls1046a-wdt, which allow
> >big-endian property.
> >
> >>
> >> Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> >> mmc nodes")
> >> Cc: stable at vger.kernel.org
> >> Signed-off-by: Meng Li <Meng.Li at windriver.com>
> >
> >after above small fix
> >
> >Reviewed-by: Frank Li <Frank.Li at nxp.com>
> >
> >> ---
> >>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> >> index 0baf256b4400..983b2f0e8797 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> >> @@ -687,11 +687,12 @@ lpuart5: serial at 29a0000 {
> >>              };
> >>
> >>              wdog0: watchdog at 2ad0000 {
> >> -                    compatible = "fsl,imx21-wdt";
> >> +                    compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
> 
> So ls1046a is really compatible with imx21?
> 

Yes. I think LS1046/ls1043 use the same watchdog device as imx21

Thanks,
LImeng

> Regards,
> Peng
> 
> >>                      reg = <0x0 0x2ad0000 0x0 0x10000>;
> >>                      interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> >>                      clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> >>                                          QORIQ_CLK_PLL_DIV(2)>;
> >> +                    big-endian;
> >>              };
> >>
> >>              edma0: dma-controller at 2c00000 {
> >> --
> >> 2.34.1
> >>