[PATCH v8 2/9] PCI: stm32: Add PCIe host support for STM32MP25
Christian Bruel
christian.bruel at foss.st.com
Wed Jun 4 09:35:49 PDT 2025
>>>>>> +
>>>>>> + ret = devm_pm_runtime_enable(dev);
>>>>>> + if (ret < 0) {
>>>>>> + dev_err(dev, "Failed to enable runtime PM %d\n", ret);
>>>>>> + return ret;
>>>>>> + }
>>>>>> +
>>>>>> + pm_runtime_get_noresume(dev);
>>>>>> +
>>>>>
>>>>> I know that a lot of the controller drivers do this for no obvious reason. But
>>>>> in this case, I believe you want to enable power domain or genpd before
>>>>> registering the host bridge. Is that right?
>>>>
...
Runtime PM was broken in version 6.6 without pm_runtime_get_noresume()
On the 6.15 baseline, without this call, pm_genpd_summary reports the
correct information: active when a device is plugged, and suspended when not
So, I can proceed without pm_runtime_get_noresume(), as you mentioned in
your review.
I suspect the other platforms might have this call for the same
historical reasons.
thank you,
Christian
More information about the linux-arm-kernel
mailing list