[PATCH v1 6/7] clocksource/drivers/cs5535: Add module owner
William McVicker
willmcvicker at google.com
Tue Jun 3 11:00:37 PDT 2025
On 06/02/2025, Daniel Lezcano wrote:
> The conversion to modules requires a correct handling of the module
> refcount in order to prevent to unload it if it is in use. That is
> especially true with the clockevents where there is no function to
> unregister them.
>
> The core time framework correctly handles the module refcount with the
> different clocksource and clockevents if the module owner is set.
>
> Add the module owner to make sure the core framework will prevent
> stupid things happening when the driver will be converted into a
> module.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
Reviewed-by: Will McVicker <willmcvicker at google.com>
Thanks,
Will
> ---
> drivers/clocksource/timer-cs5535.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/timer-cs5535.c b/drivers/clocksource/timer-cs5535.c
> index d47acfe848ae..8af666c39890 100644
> --- a/drivers/clocksource/timer-cs5535.c
> +++ b/drivers/clocksource/timer-cs5535.c
> @@ -101,6 +101,7 @@ static struct clock_event_device cs5535_clockevent = {
> .tick_resume = mfgpt_shutdown,
> .set_next_event = mfgpt_next_event,
> .rating = 250,
> + .owner = THIS_MODULE,
> };
>
> static irqreturn_t mfgpt_tick(int irq, void *dev_id)
> --
> 2.43.0
>
More information about the linux-arm-kernel
mailing list