[PATCH v4 07/10] coresight: ctcu: enable byte-cntr for TMC ETR devices
Jie Gan
jie.gan at oss.qualcomm.com
Fri Jul 25 03:08:03 PDT 2025
The byte-cntr function provided by the CTCU device is used to transfer data
from the ETR buffer to the userspace. An interrupt is triggered if the data
size exceeds the threshold set in the BYTECNTRVAL register. The interrupt
handler counts the number of triggered interruptions and the read function
will read the data from the synced ETR buffer.
Switching the sysfs_buf when current buffer is full or the timeout is
triggered and resets rrp and rwp registers after switched the buffer.
The synced buffer will become available for reading after the switch.
Signed-off-by: Jie Gan <jie.gan at oss.qualcomm.com>
---
.../testing/sysfs-bus-coresight-devices-ctcu | 5 +
drivers/hwtracing/coresight/Makefile | 2 +-
.../coresight/coresight-ctcu-byte-cntr.c | 364 ++++++++++++++++++
.../hwtracing/coresight/coresight-ctcu-core.c | 94 ++++-
drivers/hwtracing/coresight/coresight-ctcu.h | 60 ++-
.../hwtracing/coresight/coresight-tmc-etr.c | 16 +
drivers/hwtracing/coresight/coresight-tmc.h | 2 +
7 files changed, 530 insertions(+), 13 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ctcu
create mode 100644 drivers/hwtracing/coresight/coresight-ctcu-byte-cntr.c
diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-ctcu b/Documentation/ABI/testing/sysfs-bus-coresight-devices-ctcu
new file mode 100644
index 000000000000..43064bf1aac7
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-ctcu
@@ -0,0 +1,5 @@
+What: /sys/bus/coresight/devices/<ctcu-name>/irq_val
+Date: June 2025
+KernelVersion: 6.16
+Contact: Tingwei Zhang <tingwei.zhang at oss.qualcomm.com>; Jinlong Mao <jinlong.mao at oss.qualcomm.com>; Jie Gan <jie.gan at oss.qualcomm.com>
+Description: (RW) Configure the IRQ value for byte-cntr register.
diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile
index ab16d06783a5..821a1b06b20c 100644
--- a/drivers/hwtracing/coresight/Makefile
+++ b/drivers/hwtracing/coresight/Makefile
@@ -55,5 +55,5 @@ coresight-cti-y := coresight-cti-core.o coresight-cti-platform.o \
obj-$(CONFIG_ULTRASOC_SMB) += ultrasoc-smb.o
obj-$(CONFIG_CORESIGHT_DUMMY) += coresight-dummy.o
obj-$(CONFIG_CORESIGHT_CTCU) += coresight-ctcu.o
-coresight-ctcu-y := coresight-ctcu-core.o
+coresight-ctcu-y := coresight-ctcu-core.o coresight-ctcu-byte-cntr.o
obj-$(CONFIG_CORESIGHT_KUNIT_TESTS) += coresight-kunit-tests.o
diff --git a/drivers/hwtracing/coresight/coresight-ctcu-byte-cntr.c b/drivers/hwtracing/coresight/coresight-ctcu-byte-cntr.c
new file mode 100644
index 000000000000..83e4a17d897f
--- /dev/null
+++ b/drivers/hwtracing/coresight/coresight-ctcu-byte-cntr.c
@@ -0,0 +1,364 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <linux/coresight.h>
+#include <linux/device.h>
+#include <linux/fs.h>
+#include <linux/interrupt.h>
+#include <linux/of_irq.h>
+#include <linux/uaccess.h>
+
+#include "coresight-ctcu.h"
+#include "coresight-priv.h"
+#include "coresight-tmc.h"
+
+static irqreturn_t byte_cntr_handler(int irq, void *data)
+{
+ struct ctcu_byte_cntr *byte_cntr_data = (struct ctcu_byte_cntr *)data;
+
+ atomic_inc(&byte_cntr_data->irq_cnt);
+ wake_up(&byte_cntr_data->wq);
+
+ return IRQ_HANDLED;
+}
+
+/* Start the byte-cntr function when the path is enabled. */
+void ctcu_byte_cntr_start(struct coresight_device *csdev, struct coresight_path *path)
+{
+ struct ctcu_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
+ struct coresight_device *sink = coresight_get_sink(path);
+ struct ctcu_byte_cntr *byte_cntr_data;
+ int port_num;
+
+ if (!sink)
+ return;
+
+ port_num = coresight_get_in_port_dest(sink, csdev);
+ if (port_num < 0)
+ return;
+
+ byte_cntr_data = &drvdata->byte_cntr_data[port_num];
+ /* Don't start byte-cntr function when threshold is not set. */
+ if (!byte_cntr_data->thresh_val || byte_cntr_data->enable)
+ return;
+
+ guard(raw_spinlock_irqsave)(&byte_cntr_data->spin_lock);
+ byte_cntr_data->enable = true;
+ byte_cntr_data->reading_buf = false;
+}
+
+/* Stop the byte-cntr function when the path is disabled. */
+void ctcu_byte_cntr_stop(struct coresight_device *csdev, struct coresight_path *path)
+{
+ struct ctcu_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
+ struct coresight_device *sink = coresight_get_sink(path);
+ struct ctcu_byte_cntr *byte_cntr_data;
+ int port_num;
+
+ if (!sink || coresight_get_mode(sink) == CS_MODE_SYSFS)
+ return;
+
+ port_num = coresight_get_in_port_dest(sink, csdev);
+ if (port_num < 0)
+ return;
+
+ byte_cntr_data = &drvdata->byte_cntr_data[port_num];
+ guard(raw_spinlock_irqsave)(&byte_cntr_data->spin_lock);
+ byte_cntr_data->enable = false;
+}
+
+static void ctcu_reset_sysfs_buf(struct tmc_drvdata *drvdata)
+{
+ u32 sts;
+
+ CS_UNLOCK(drvdata->base);
+ tmc_write_rrp(drvdata, drvdata->sysfs_buf->hwaddr);
+ tmc_write_rwp(drvdata, drvdata->sysfs_buf->hwaddr);
+ sts = readl_relaxed(drvdata->base + TMC_STS) & ~TMC_STS_FULL;
+ writel_relaxed(sts, drvdata->base + TMC_STS);
+ CS_LOCK(drvdata->base);
+}
+
+static struct ctcu_byte_cntr *ctcu_get_byte_cntr_data(struct tmc_drvdata *drvdata)
+{
+ struct ctcu_byte_cntr *byte_cntr_data;
+ struct ctcu_drvdata *ctcu_drvdata;
+ struct coresight_device *helper;
+ int port;
+
+ helper = coresight_get_helper(drvdata->csdev, CORESIGHT_DEV_SUBTYPE_HELPER_CTCU);
+ if (!helper)
+ return NULL;
+
+ port = coresight_get_in_port_dest(drvdata->csdev, helper);
+ if (port < 0)
+ return NULL;
+
+ ctcu_drvdata = dev_get_drvdata(helper->dev.parent);
+ byte_cntr_data = &ctcu_drvdata->byte_cntr_data[port];
+ return byte_cntr_data;
+}
+
+static bool ctcu_byte_cntr_switch_buffer(struct tmc_drvdata *drvdata,
+ struct ctcu_byte_cntr *byte_cntr_data)
+{
+ struct etr_buf_node *nd, *next, *curr_node, *picked_node;
+ struct etr_buf *curr_buf = drvdata->sysfs_buf;
+ bool found_free_buf = false;
+
+ if (WARN_ON(!drvdata || !byte_cntr_data))
+ return found_free_buf;
+
+ /* Stop the ETR before we start the switch */
+ if (coresight_get_mode(drvdata->csdev) != CS_MODE_DISABLED)
+ tmc_etr_disable_hw_before_switching(drvdata);
+
+ list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) {
+ /* curr_buf is free for next round */
+ if (nd->sysfs_buf == curr_buf) {
+ nd->is_free = true;
+ curr_node = nd;
+ }
+
+ if (!found_free_buf && nd->is_free && nd->sysfs_buf != curr_buf) {
+ if (nd->reading)
+ continue;
+
+ picked_node = nd;
+ found_free_buf = true;
+ }
+ }
+
+ if (found_free_buf) {
+ curr_node->reading = true;
+ curr_node->pos = 0;
+ drvdata->reading_node = curr_node;
+ drvdata->sysfs_buf = picked_node->sysfs_buf;
+ drvdata->etr_buf = picked_node->sysfs_buf;
+ picked_node->is_free = false;
+ /* Reset irq_cnt for next etr_buf */
+ atomic_set(&byte_cntr_data->irq_cnt, 0);
+ /* Reset rrp and rwp when the system has switched the buffer*/
+ ctcu_reset_sysfs_buf(drvdata);
+ /* Restart the ETR when we find a free buffer */
+ if (coresight_get_mode(drvdata->csdev) != CS_MODE_DISABLED)
+ tmc_etr_enable_hw_after_switching(drvdata);
+ }
+
+ return found_free_buf;
+}
+
+/*
+ * ctcu_byte_cntr_get_data() - reads data from the deactivated and filled buffer.
+ * The byte-cntr reading work reads data from the deactivated and filled buffer.
+ * The read operation waits for a buffer to become available, either filled or
+ * upon timeout, and then reads trace data from the synced buffer.
+ */
+static ssize_t ctcu_byte_cntr_get_data(struct tmc_drvdata *drvdata, loff_t pos,
+ size_t len, char **bufpp)
+{
+ struct etr_buf *sysfs_buf = drvdata->sysfs_buf;
+ struct device *dev = &drvdata->csdev->dev;
+ ssize_t actual, size = sysfs_buf->size;
+ struct ctcu_byte_cntr *byte_cntr_data;
+ struct etr_buf_node *nd, *next;
+ size_t thresh_val;
+ atomic_t *irq_cnt;
+ int ret;
+
+ byte_cntr_data = ctcu_get_byte_cntr_data(drvdata);
+ if (!byte_cntr_data)
+ return -EINVAL;
+
+ thresh_val = byte_cntr_data->thresh_val;
+ irq_cnt = &byte_cntr_data->irq_cnt;
+
+wait_buffer:
+ if (!byte_cntr_data->reading_buf) {
+ ret = wait_event_interruptible_timeout(byte_cntr_data->wq,
+ ((atomic_read(irq_cnt) + 1) * thresh_val >= size) ||
+ !byte_cntr_data->enable,
+ BYTE_CNTR_TIMEOUT);
+ if (ret < 0)
+ return ret;
+ /*
+ * The current etr_buf is almost full or timeout is triggered,
+ * so switch the buffer and mark the switched buffer as reading.
+ */
+ if (byte_cntr_data->enable) {
+ if (!ctcu_byte_cntr_switch_buffer(drvdata, byte_cntr_data)) {
+ dev_err(dev, "Switch buffer failed for byte-cntr\n");
+ return -EINVAL;
+ }
+
+ byte_cntr_data->reading_buf = true;
+ } else {
+ if (!drvdata->reading_node) {
+ list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) {
+ if (nd->sysfs_buf == sysfs_buf) {
+ nd->pos = 0;
+ drvdata->reading_node = nd;
+ break;
+ }
+ }
+ }
+
+ pos = drvdata->reading_node->pos;
+ actual = drvdata->read_ops->get_trace_data(drvdata, pos, len, bufpp);
+ if (actual > 0) {
+ byte_cntr_data->total_size += actual;
+ return actual;
+ }
+
+ drvdata->reading_node = NULL;
+
+ /* Exit byte-cntr reading */
+ return -EINVAL;
+ }
+ }
+
+ /* Check the status of current etr_buf*/
+ if ((atomic_read(irq_cnt) + 1) * thresh_val >= size)
+ /*
+ * Unlikely to find a free buffer to switch, so just disable
+ * the ETR for a while.
+ */
+ if (!ctcu_byte_cntr_switch_buffer(drvdata, byte_cntr_data))
+ dev_info(dev, "No available buffer to store data, disable ETR\n");
+
+ pos = drvdata->reading_node->pos;
+ actual = drvdata->read_ops->get_trace_data(drvdata, pos, len, bufpp);
+ if (actual == 0) {
+ /* Reading work for marked buffer has finished, reset flags */
+ drvdata->reading_node->reading = false;
+ byte_cntr_data->reading_buf = false;
+ drvdata->reading_node = NULL;
+
+ /* Nothing in the buffer, wait for next buffer to be filled */
+ goto wait_buffer;
+ }
+ byte_cntr_data->total_size += actual;
+
+ return actual;
+}
+
+static int ctcu_read_prepare_byte_cntr(struct tmc_drvdata *drvdata)
+{
+ struct ctcu_byte_cntr *byte_cntr_data;
+ unsigned long flags;
+ int ret = 0;
+
+ /* config types are set a boot time and never change */
+ if (WARN_ON_ONCE(drvdata->config_type != TMC_CONFIG_TYPE_ETR))
+ return -EINVAL;
+
+ byte_cntr_data = ctcu_get_byte_cntr_data(drvdata);
+ if (!byte_cntr_data)
+ return -EINVAL;
+
+ /*
+ * The threshold value must not exceed the buffer size.
+ * A margin should be maintained between the two values to account
+ * for the time gap between the interrupt and buffer switching.
+ */
+ if (byte_cntr_data->thresh_val + SZ_16K >= drvdata->size) {
+ dev_err(&drvdata->csdev->dev, "The threshold value is too large\n");
+ return -EINVAL;
+ }
+
+ raw_spin_lock_irqsave(&drvdata->spinlock, flags);
+ if (byte_cntr_data->reading) {
+ ret = -EBUSY;
+ goto out_unlock;
+ }
+
+ byte_cntr_data->reading = true;
+ raw_spin_unlock_irqrestore(&drvdata->spinlock, flags);
+ /* Insert current sysfs_buf into the list */
+ ret = tmc_create_etr_buf_node(drvdata, drvdata->sysfs_buf);
+ if (!ret) {
+ /*
+ * Add one more sysfs_buf for byte-cntr function, byte-cntr always reads
+ * the data from the buffer which has been synced. Switch the buffer when
+ * the used buffer is nearly full. The used buffer will be synced and made
+ * available for reading before switch.
+ */
+ ret = tmc_create_etr_buf_node(drvdata, NULL);
+ if (ret) {
+ dev_err(&drvdata->csdev->dev, "Failed to create etr_buf_node\n");
+ tmc_clean_etr_buf_list(drvdata);
+ byte_cntr_data->reading = false;
+ goto out;
+ }
+ }
+
+ raw_spin_lock_irqsave(&drvdata->spinlock, flags);
+ atomic_set(&byte_cntr_data->irq_cnt, 0);
+ enable_irq(byte_cntr_data->irq_num);
+ enable_irq_wake(byte_cntr_data->irq_num);
+ byte_cntr_data->total_size = 0;
+
+out_unlock:
+ raw_spin_unlock_irqrestore(&drvdata->spinlock, flags);
+
+out:
+ return ret;
+}
+
+static int ctcu_read_unprepare_byte_cntr(struct tmc_drvdata *drvdata)
+{
+ struct device *dev = &drvdata->csdev->dev;
+ struct ctcu_byte_cntr *byte_cntr_data;
+
+ byte_cntr_data = ctcu_get_byte_cntr_data(drvdata);
+ if (!byte_cntr_data)
+ return -EINVAL;
+
+ guard(raw_spinlock_irqsave)(&byte_cntr_data->spin_lock);
+ disable_irq_wake(byte_cntr_data->irq_num);
+ disable_irq(byte_cntr_data->irq_num);
+ byte_cntr_data->reading = false;
+ tmc_clean_etr_buf_list(drvdata);
+ dev_dbg(dev, "send data total size:%llu bytes\n", byte_cntr_data->total_size);
+
+ return 0;
+}
+
+static const struct tmc_read_ops byte_cntr_read_ops = {
+ .read_prepare = ctcu_read_prepare_byte_cntr,
+ .read_unprepare = ctcu_read_unprepare_byte_cntr,
+ .get_trace_data = ctcu_byte_cntr_get_data,
+};
+
+void ctcu_byte_cntr_init(struct device *dev, struct ctcu_drvdata *drvdata, int etr_num)
+{
+ struct ctcu_byte_cntr *byte_cntr_data;
+ struct device_node *nd = dev->of_node;
+ int irq_num, ret, i;
+
+ drvdata->byte_cntr_read_ops = &byte_cntr_read_ops;
+ for (i = 0; i < etr_num; i++) {
+ byte_cntr_data = &drvdata->byte_cntr_data[i];
+ irq_num = of_irq_get_byname(nd, byte_cntr_data->irq_name);
+ if (irq_num < 0) {
+ dev_err(dev, "Failed to get IRQ from DT for %s\n",
+ byte_cntr_data->irq_name);
+ continue;
+ }
+
+ ret = devm_request_irq(dev, irq_num, byte_cntr_handler,
+ IRQF_TRIGGER_RISING | IRQF_SHARED,
+ dev_name(dev), byte_cntr_data);
+ if (ret) {
+ dev_err(dev, "Failed to register IRQ for %s\n",
+ byte_cntr_data->irq_name);
+ continue;
+ }
+
+ byte_cntr_data->irq_num = irq_num;
+ disable_irq(byte_cntr_data->irq_num);
+ init_waitqueue_head(&byte_cntr_data->wq);
+ }
+}
diff --git a/drivers/hwtracing/coresight/coresight-ctcu-core.c b/drivers/hwtracing/coresight/coresight-ctcu-core.c
index 3bdedf041390..8fc08e42187e 100644
--- a/drivers/hwtracing/coresight/coresight-ctcu-core.c
+++ b/drivers/hwtracing/coresight/coresight-ctcu-core.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/slab.h>
+#include <linux/sizes.h>
#include "coresight-ctcu.h"
#include "coresight-priv.h"
@@ -45,17 +46,23 @@ DEFINE_CORESIGHT_DEVLIST(ctcu_devs, "ctcu");
#define CTCU_ATID_REG_BIT(traceid) (traceid % 32)
#define CTCU_ATID_REG_SIZE 0x10
+#define CTCU_ETR0_IRQCTRL 0x6c
+#define CTCU_ETR1_IRQCTRL 0x70
#define CTCU_ETR0_ATID0 0xf8
#define CTCU_ETR1_ATID0 0x108
static const struct ctcu_etr_config sa8775p_etr_cfgs[] = {
{
- .atid_offset = CTCU_ETR0_ATID0,
- .port_num = 0,
+ .atid_offset = CTCU_ETR0_ATID0,
+ .irq_ctrl_offset = CTCU_ETR0_IRQCTRL,
+ .irq_name = "etr0",
+ .port_num = 0,
},
{
- .atid_offset = CTCU_ETR1_ATID0,
- .port_num = 1,
+ .atid_offset = CTCU_ETR1_ATID0,
+ .irq_ctrl_offset = CTCU_ETR1_IRQCTRL,
+ .irq_name = "etr1",
+ .port_num = 1,
},
};
@@ -64,6 +71,76 @@ static const struct ctcu_config sa8775p_cfgs = {
.num_etr_config = ARRAY_SIZE(sa8775p_etr_cfgs),
};
+static void ctcu_program_register(struct ctcu_drvdata *drvdata, u32 val, u32 offset)
+{
+ CS_UNLOCK(drvdata->base);
+ ctcu_writel(drvdata, val, offset);
+ CS_LOCK(drvdata->base);
+}
+
+static ssize_t irq_threshold_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct ctcu_drvdata *drvdata = dev_get_drvdata(dev->parent);
+ int i, len = 0;
+
+ for (i = 0; i < ETR_MAX_NUM; i++) {
+ if (drvdata->byte_cntr_data[i].irq_ctrl_offset)
+ len += scnprintf(buf + len, PAGE_SIZE - len, "%u ",
+ drvdata->byte_cntr_data[i].thresh_val);
+ }
+
+ len += scnprintf(buf + len, PAGE_SIZE - len, "\n");
+
+ return len;
+}
+
+/* Program a valid value into IRQCTRL register will enable byte-cntr interrupt */
+static ssize_t irq_threshold_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t size)
+{
+ struct ctcu_drvdata *drvdata = dev_get_drvdata(dev->parent);
+ u32 thresh_vals[ETR_MAX_NUM] = { 0 };
+ u32 irq_ctrl_offset;
+ int num, i;
+
+ num = sscanf(buf, "%i %i", &thresh_vals[0], &thresh_vals[1]);
+ if (num <= 0 || num > ETR_MAX_NUM)
+ return -EINVAL;
+
+ /* Threshold 0 disables the interruption. */
+ guard(raw_spinlock_irqsave)(&drvdata->spin_lock);
+ for (i = 0; i < num; i++) {
+ /* A small threshold will result in a large number of interruptions */
+ if (thresh_vals[i] && thresh_vals[i] < SZ_4K)
+ return -EINVAL;
+
+ if (drvdata->byte_cntr_data[i].irq_ctrl_offset) {
+ drvdata->byte_cntr_data[i].thresh_val = thresh_vals[i];
+ irq_ctrl_offset = drvdata->byte_cntr_data[i].irq_ctrl_offset;
+ /* A one value for IRQCTRL register represents 8 bytes */
+ ctcu_program_register(drvdata, thresh_vals[i] / 8, irq_ctrl_offset);
+ }
+ }
+
+ return size;
+}
+static DEVICE_ATTR_RW(irq_threshold);
+
+static struct attribute *ctcu_attrs[] = {
+ &dev_attr_irq_threshold.attr,
+ NULL,
+};
+
+static struct attribute_group ctcu_attr_grp = {
+ .attrs = ctcu_attrs,
+};
+
+static const struct attribute_group *ctcu_attr_grps[] = {
+ &ctcu_attr_grp,
+ NULL,
+};
+
static void ctcu_program_atid_register(struct ctcu_drvdata *drvdata, u32 reg_offset,
u8 bit, bool enable)
{
@@ -143,6 +220,8 @@ static int ctcu_enable(struct coresight_device *csdev, enum cs_mode mode, void *
{
struct coresight_path *path = (struct coresight_path *)data;
+ ctcu_byte_cntr_start(csdev, path);
+
return ctcu_set_etr_traceid(csdev, path, true);
}
@@ -150,6 +229,8 @@ static int ctcu_disable(struct coresight_device *csdev, void *data)
{
struct coresight_path *path = (struct coresight_path *)data;
+ ctcu_byte_cntr_stop(csdev, path);
+
return ctcu_set_etr_traceid(csdev, path, false);
}
@@ -200,7 +281,11 @@ static int ctcu_probe(struct platform_device *pdev)
for (i = 0; i < cfgs->num_etr_config; i++) {
etr_cfg = &cfgs->etr_cfgs[i];
drvdata->atid_offset[i] = etr_cfg->atid_offset;
+ drvdata->byte_cntr_data[i].irq_name = etr_cfg->irq_name;
+ drvdata->byte_cntr_data[i].irq_ctrl_offset =
+ etr_cfg->irq_ctrl_offset;
}
+ ctcu_byte_cntr_init(dev, drvdata, cfgs->num_etr_config);
}
}
@@ -212,6 +297,7 @@ static int ctcu_probe(struct platform_device *pdev)
desc.subtype.helper_subtype = CORESIGHT_DEV_SUBTYPE_HELPER_CTCU;
desc.pdata = pdata;
desc.dev = dev;
+ desc.groups = ctcu_attr_grps;
desc.ops = &ctcu_ops;
desc.access = CSDEV_ACCESS_IOMEM(base);
diff --git a/drivers/hwtracing/coresight/coresight-ctcu.h b/drivers/hwtracing/coresight/coresight-ctcu.h
index e9594c38dd91..894e375277c4 100644
--- a/drivers/hwtracing/coresight/coresight-ctcu.h
+++ b/drivers/hwtracing/coresight/coresight-ctcu.h
@@ -5,19 +5,28 @@
#ifndef _CORESIGHT_CTCU_H
#define _CORESIGHT_CTCU_H
+
+#include <linux/time.h>
#include "coresight-trace-id.h"
+#include "coresight-tmc.h"
/* Maximum number of supported ETR devices for a single CTCU. */
#define ETR_MAX_NUM 2
+#define BYTE_CNTR_TIMEOUT (5 * HZ)
+
/**
* struct ctcu_etr_config
* @atid_offset: offset to the ATID0 Register.
- * @port_num: in-port number of CTCU device that connected to ETR.
+ * @port_num: in-port number of the CTCU device that connected to ETR.
+ * @irq_ctrl_offset: offset to the BYTECNTRVAL register.
+ * @irq_name: IRQ name in dt node.
*/
struct ctcu_etr_config {
const u32 atid_offset;
const u32 port_num;
+ const u32 irq_ctrl_offset;
+ const char *irq_name;
};
struct ctcu_config {
@@ -25,15 +34,50 @@ struct ctcu_config {
int num_etr_config;
};
-struct ctcu_drvdata {
- void __iomem *base;
- struct clk *apb_clk;
- struct device *dev;
- struct coresight_device *csdev;
+/**
+ * struct ctcu_byte_cntr
+ * @enable: indicates that byte_cntr function is enabled or not.
+ * @reading: indicates that byte-cntr reading is started.
+ * @reading_buf: indicates that byte-cntr is reading data from the buffer.
+ * @thresh_val: threshold to trigger a interruption.
+ * @total_size: total size of transferred data.
+ * @irq_num: allocated number of the IRQ.
+ * @irq_cnt: IRQ count number for triggered interruptions.
+ * @wq: waitqueue for reading data from ETR buffer.
+ * @spin_lock: spinlock of byte_cntr_data.
+ * @irq_ctrl_offset: offset to the BYTECNTVAL Register.
+ * @irq_name: IRQ name defined in DT.
+ */
+struct ctcu_byte_cntr {
+ bool enable;
+ bool reading;
+ bool reading_buf;
+ u32 thresh_val;
+ u64 total_size;
+ int irq_num;
+ atomic_t irq_cnt;
+ wait_queue_head_t wq;
raw_spinlock_t spin_lock;
- u32 atid_offset[ETR_MAX_NUM];
+ u32 irq_ctrl_offset;
+ const char *irq_name;
+};
+
+struct ctcu_drvdata {
+ void __iomem *base;
+ struct clk *apb_clk;
+ struct device *dev;
+ struct coresight_device *csdev;
+ struct ctcu_byte_cntr byte_cntr_data[ETR_MAX_NUM];
+ raw_spinlock_t spin_lock;
+ u32 atid_offset[ETR_MAX_NUM];
/* refcnt for each traceid of each sink */
- u8 traceid_refcnt[ETR_MAX_NUM][CORESIGHT_TRACE_ID_RES_TOP];
+ u8 traceid_refcnt[ETR_MAX_NUM][CORESIGHT_TRACE_ID_RES_TOP];
+ const struct tmc_read_ops *byte_cntr_read_ops;
};
+/* Byte-cntr functions */
+void ctcu_byte_cntr_start(struct coresight_device *csdev, struct coresight_path *path);
+void ctcu_byte_cntr_stop(struct coresight_device *csdev, struct coresight_path *path);
+void ctcu_byte_cntr_init(struct device *dev, struct ctcu_drvdata *drvdata, int port_num);
+
#endif
diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index e8ecb3e087ab..c2a4ac3e37b3 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
@@ -1117,6 +1117,12 @@ static int __tmc_etr_enable_hw(struct tmc_drvdata *drvdata)
return rc;
}
+int tmc_etr_enable_hw_after_switching(struct tmc_drvdata *drvdata)
+{
+ return __tmc_etr_enable_hw(drvdata);
+}
+EXPORT_SYMBOL_GPL(tmc_etr_enable_hw_after_switching);
+
static int tmc_etr_enable_hw(struct tmc_drvdata *drvdata,
struct etr_buf *etr_buf)
{
@@ -1163,6 +1169,10 @@ ssize_t tmc_etr_get_sysfs_trace(struct tmc_drvdata *drvdata,
ssize_t actual = len;
struct etr_buf *etr_buf = drvdata->sysfs_buf;
+ /* Reading the buffer from the buf_node if it exists*/
+ if (drvdata->reading_node)
+ etr_buf = drvdata->reading_node->sysfs_buf;
+
if (pos + actual > etr_buf->len)
actual = etr_buf->len - pos;
if (actual <= 0)
@@ -1226,6 +1236,12 @@ static void __tmc_etr_disable_hw(struct tmc_drvdata *drvdata)
}
+void tmc_etr_disable_hw_before_switching(struct tmc_drvdata *drvdata)
+{
+ __tmc_etr_disable_hw(drvdata);
+}
+EXPORT_SYMBOL_GPL(tmc_etr_disable_hw_before_switching);
+
void tmc_etr_disable_hw(struct tmc_drvdata *drvdata)
{
__tmc_etr_disable_hw(drvdata);
diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
index 2ad8e288c94b..6f42cd392e1b 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.h
+++ b/drivers/hwtracing/coresight/coresight-tmc.h
@@ -480,5 +480,7 @@ struct etr_buf *tmc_etr_get_buffer(struct coresight_device *csdev,
extern const struct attribute_group coresight_etr_group;
void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata);
int tmc_create_etr_buf_node(struct tmc_drvdata *drvdata, struct etr_buf *alloc_buf);
+int tmc_etr_enable_hw_after_switching(struct tmc_drvdata *drvdata);
+void tmc_etr_disable_hw_before_switching(struct tmc_drvdata *drvdata);
#endif
--
2.34.1
More information about the linux-arm-kernel
mailing list