[PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions
Alim Akhtar
alim.akhtar at samsung.com
Wed Jul 23 22:53:15 PDT 2025
Hi Sangwook
> -----Original Message-----
> From: Sangwook Shin <sw617.shin at samsung.com>
> Sent: Monday, July 14, 2025 11:25 AM
> To: krzk at kernel.org; alim.akhtar at samsung.com; wim at linux-watchdog.org;
> linux at roeck-us.net
> Cc: linux-arm-kernel at lists.infradead.org; linux-samsung-
> soc at vger.kernel.org; linux-watchdog at vger.kernel.org; linux-
> kernel at vger.kernel.org; Sangwook Shin <sw617.shin at samsung.com>
> Subject: [PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded
> values with macro definitions
>
> Modify the code to utilize macro-defined values instead of hardcoded values.
> The value 0x100 in the s3c2410wdt_set_heartbeat function represents
> S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its
> meaning difficult to understand and reducing code readability.
>
> Signed-off-by: Sangwook Shin <sw617.shin at samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar at samsung.com>
More information about the linux-arm-kernel
mailing list