[PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
Krzysztof Kozlowski
krzk at kernel.org
Tue Jul 22 23:45:29 PDT 2025
On 21/07/2025 22:17, Erik Beck wrote:
>
> Signed-off-by: Erik Beck <xunil at tahomasoft.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please version your patches correctly, e.g. use b4 or git format-patch
-vX, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../rockchip/rk3568-linkstar-h68k-1432v1.dts | 740 ++++++++++++++++++
> 2 files changed, 741 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
>
...
> + hdmi-con {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi_con_in: endpoint {
> + remote-endpoint = <&hdmi_out_con>;
> + };
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&reset_button_pin>;
> + pinctrl-names = "default";
> +
> + /* Middle inset/recessed button,
> + marked by clockwise arrow/circle */
Messed indentation
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list