[PATCH v4 05/10] coresight: Appropriately disable trace bus clocks

Suzuki K Poulose suzuki.poulose at arm.com
Mon Jul 21 02:20:42 PDT 2025


On 27/06/2025 12:51, Leo Yan wrote:
> Some CoreSight components have trace bus clocks 'atclk' and are enabled
> using clk_prepare_enable().  These clocks are not disabled when modules
> exit.
> 
> As atclk is optional, use devm_clk_get_optional_enabled() to manage it.
> The benefit is the driver model layer can automatically disable and
> release clocks.
> 
> Check the returned value with IS_ERR() to detect errors but leave the
> NULL pointer case if the clock is not found.  And remove the error
> handling codes which are no longer needed.
> 
> Fixes: d1839e687773 ("coresight: etm: retrieve and handle atclk")

I would drop this tag as I don't see what we are fixing ?
If there is indeed something, I would recommend:
  - Call it out in the commit description.
  - Move that as a separate patch, so that it can be
    safely backported without touching all the other drivers.

If you agree with the above, I will drop the "Fixes" tag and
can merge it.

Suzuki




More information about the linux-arm-kernel mailing list