[PATCH] irqchip/gic-v3: fix resource leak in partition_domain_translate()
jackysliu
1972843537 at qq.com
Mon Jul 21 00:28:04 PDT 2025
There is a device node reference leak in partition_domain_translate().
After the function obtains the device node np via of_find_node_by_phandle,
it does not call of_node_put(np) to release the node reference
in both the error path and the normal return path.
This causes the node reference count to increase each time
the function is called, causing a resource leak.
This issue was detected by rule based static tools
developed by Tencent.
Fixes: 87228532e7e9 ("irqchip: Switch to of_fwnode_handle()")
Signed-off-by: jackysliu <1972843537 at qq.com>
---
drivers/irqchip/irq-gic-v3.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index efc791c43d44..61c1d404b726 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1821,12 +1821,16 @@ static int partition_domain_translate(struct irq_domain *d,
return -EINVAL;
ret = gic_irq_domain_translate(d, fwspec, &ppi_intid, type);
- if (WARN_ON_ONCE(ret))
+ if (WARN_ON_ONCE(ret)) {
+ of_node_put(np);
return 0;
+ }
ppi_idx = __gic_get_ppi_index(ppi_intid);
ret = partition_translate_id(gic_data.ppi_descs[ppi_idx],
of_fwnode_handle(np));
+ of_node_put(np);
+
if (ret < 0)
return ret;
--
2.43.5
More information about the linux-arm-kernel
mailing list