[PATCH 19/26] media: mc-entity: Add link_validate_context
Jacopo Mondi
jacopo.mondi at ideasonboard.com
Thu Jul 17 03:45:45 PDT 2025
Add an 'override' of the link_validate() media entity operation that
accepts a media_device_context as second argument to allow entities
to validate the link state in the provided media_device context.
Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
---
drivers/media/mc/mc-entity.c | 23 +++++++++++++++++++----
include/media/media-entity.h | 6 ++++++
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
index f421d6d74630bb96400d39d805c5db5d3d1ff913..675ceaede0d10a2420b8ea6a89e5963dcfde5ffe 100644
--- a/drivers/media/mc/mc-entity.c
+++ b/drivers/media/mc/mc-entity.c
@@ -884,6 +884,8 @@ __media_pipeline_start_context(struct media_pad *origin,
* the connected sink pad to avoid duplicating checks.
*/
for_each_media_entity_data_link(entity, link) {
+ const struct media_entity_operations *ops;
+
/* Skip links unrelated to the current pad. */
if (link->sink != pad && link->source != pad)
continue;
@@ -902,13 +904,23 @@ __media_pipeline_start_context(struct media_pad *origin,
if (link->sink != pad)
continue;
- if (!entity->ops || !entity->ops->link_validate)
+ ops = entity->ops;
+ if (!ops || (!ops->link_validate &&
+ !ops->link_validate_context))
continue;
- ret = entity->ops->link_validate(link);
+ if (mdev_context && ops->link_validate_context)
+ ret = ops->link_validate_context(link,
+ mdev_context);
+ else
+ ret = entity->ops->link_validate(link);
+
if (ret) {
dev_dbg(mdev->dev,
- "Link '%s':%u -> '%s':%u failed validation: %d\n",
+ "%sink '%s':%u -> '%s':%u failed validation: %d\n",
+ (mdev_context &&
+ ops->link_validate_context) ?
+ "Context l" : "L",
link->source->entity->name,
link->source->index,
link->sink->entity->name,
@@ -917,7 +929,10 @@ __media_pipeline_start_context(struct media_pad *origin,
}
dev_dbg(mdev->dev,
- "Link '%s':%u -> '%s':%u is valid\n",
+ "%sink '%s':%u -> '%s':%u is valid\n",
+ (mdev_context &&
+ ops->link_validate_context) ?
+ "Context l" : "L",
link->source->entity->name,
link->source->index,
link->sink->entity->name,
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index b60c311ab390beb6931fe8f2bbe8939e11cda452..b053a0baee4031a464edf506d3d131bacb810f81 100644
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
@@ -295,6 +295,10 @@ struct media_entity_context {
* @link_validate: Return whether a link is valid from the entity point of
* view. The media_pipeline_start() function
* validates all links by calling this operation. Optional.
+ * @link_validate_context: Return whether a link is valid from the entity
+ * context point of view. The
+ * media_pipeline_start_context() function validates all
+ * links calling this operation. Optional.
* @has_pad_interdep: Return whether two pads of the entity are
* interdependent. If two pads are interdependent they are
* part of the same pipeline and enabling one of the pads
@@ -327,6 +331,8 @@ struct media_entity_operations {
const struct media_pad *local,
const struct media_pad *remote, u32 flags);
int (*link_validate)(struct media_link *link);
+ int (*link_validate_context)(struct media_link *link,
+ struct media_device_context *mdev_context);
bool (*has_pad_interdep)(struct media_entity *entity, unsigned int pad0,
unsigned int pad1);
int (*alloc_context)(struct media_entity *entity,
--
2.49.0
More information about the linux-arm-kernel
mailing list