[PATCH v2] dt-bindings: interrupt-controller: aspeed: Add parent node compatibles and refine documentation
Krzysztof Kozlowski
krzk at kernel.org
Wed Jul 16 01:21:42 PDT 2025
On Tue, Jul 15, 2025 at 10:42:58AM +0800, Ryan Chen wrote:
> - Add 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible
> strings for parent interrupt controller nodes, in addition to the
> existing 'aspeed,ast2700-intc-ic' for child nodes.
> - Clarify the relationship and function of INTC0, INTC1, and the GIC.
> - Update and clarify documentation, block diagram, and examples
> to reflect the hierarchy and compatible usage.
> - Documentation and example refine.
So 7 lines describing obvious - what you did and three lines below
describing non-obvious, why you did it. It should be reversed.
>
> This change allows the device tree and driver to distinguish between
Why driver needs would matter here?
> parent (top-level) and child (group) interrupt controller nodes,
> enabling more precise driver matching SOC register space allocation.
This just does not make sense. You do not change "precise driver
matching" via bindings. You fix driver. Especially that there is no
driver patch here at all and aspeed,ast2700-intc0 are totally unused!
Don't add ABI which has no users.
Again, you need to start describing the hardware and the REASONS BEHIND
from the hardware point of view. Not drivers.
This change alone based on above explanation makes no sense at all.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list