[PATCH next] spi: stm32-ospi: Fix NULL vs IS_ERR() bug in stm32_ospi_get_resources()
Dan Carpenter
dan.carpenter at linaro.org
Tue Jul 15 16:01:39 PDT 2025
This code was changed from using devm_ioremap() which returns NULL to
using devm_ioremap_resource() which returns error pointers. Update
the error checking to match.
Fixes: defe01abfb7f ("spi: stm32-ospi: Use of_reserved_mem_region_to_resource() for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
---
drivers/spi/spi-stm32-ospi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c
index 72baa402a2c3..f36fd36da269 100644
--- a/drivers/spi/spi-stm32-ospi.c
+++ b/drivers/spi/spi-stm32-ospi.c
@@ -823,9 +823,9 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
if (!ret) {
ospi->mm_size = resource_size(res);
ospi->mm_base = devm_ioremap_resource(dev, res);
- if (!ospi->mm_base) {
+ if (IS_ERR(ospi->mm_base)) {
dev_err(dev, "unable to map memory region: %pR\n", res);
- ret = -ENOMEM;
+ ret = PTR_ERR(ospi->mm_base);
goto err_dma;
}
--
2.47.2
More information about the linux-arm-kernel
mailing list