[PATCH 4/6] sound: soc: qcom: qdsp6: q6dsp-lpass-clocks: convert from round_rate() to determine_rate()
Brian Masney
bmasney at redhat.com
Mon Jul 14 13:39:31 PDT 2025
Hi Konrad,
On Thu, Jul 10, 2025 at 12:09 PM Konrad Dybcio
<konrad.dybcio at oss.qualcomm.com> wrote:
> On 7/10/25 5:51 PM, Brian Masney wrote:
> > The round_rate() clk ops is deprecated, so migrate this driver from
> > round_rate() to determine_rate() using the Coccinelle semantic patch
> > on the cover letter of this series.
> >
> > Signed-off-by: Brian Masney <bmasney at redhat.com>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio at oss.qualcomm.com>
>
> come to think of it, there are a lot of drivers that can not
> do any rate rounding - perhaps we could introduce a NOP implementation
> in the clk core that we could reference, instead of copypasting
> int foo(...) { "return 0" }?
I'll look at that for a second round of cleanup once all of the
round_rates have been removed from the tree. From what I recall about
the ~200 or so round_rate implementations in the kernel tree, there
were maybe only 5 or so that cover this noop case. QC seemed to have
the most from what I recall.
It wouldn't be hard to make a Coccinelle script to look for the noop
determine_rate() implementations.
Brian
More information about the linux-arm-kernel
mailing list