[PATCH v6 3/5] dt-bindings: arm: Add qcom,qmi-id for remote etm

Krzysztof Kozlowski krzk at kernel.org
Sun Jul 13 23:47:41 PDT 2025


On Fri, Jul 11, 2025 at 02:40:29AM -0700, Mao Jinlong wrote:
> Remote etm binding change was merged to fix the dt warning. Driver
> changes were not merged at that time. qcom,qmi-instance-id is
> required for remote etm driver to find the remote subsystem connection.

Again, driver... 


> It is the instance id used by qmi to communicate with remote processor.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao at quicinc.com>
> ---
>  .../bindings/arm/qcom,coresight-remote-etm.yaml          | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> index 4fd5752978cd..bd78f6bc2fdf 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> @@ -20,6 +20,12 @@ properties:
>    compatible:
>      const: qcom,coresight-remote-etm
>  
> +  qcom,qmi-instance-id:

Don't come with another, 20th property for your remote proc
architecture. Use existing properties.

This pattern in qcom is extremely confusing - similar thing for remote
proc called 20 different ways, just because in downstream you have 20
different drivers.

NAK

Come with unified schema for existing and future properties like that.
Assuming this is NOT FOR DRIVER in the first place.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list