[PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support.
Parvathi Pudi
parvathi at couthit.com
Fri Jul 11 05:33:08 PDT 2025
Hi,
> On Wed, 2 Jul 2025 20:47:49 +0530 Parvathi Pudi wrote:
>> + if (emac->port_id) {
>> + regmap_update_bits
>> + (prueth->mii_rt,
>> + PRUSS_MII_RT_TXCFG1,
>> + PRUSS_MII_RT_TXCFG_TX_CLK_DELAY_MASK,
>> + delay);
>
> Instead of breaking the lines up like this you should factor the code
> out or find some other way to reduce the indentation.
>
Sure, we will address this in the next version.
>> + qid = icssm_prueth_get_tx_queue_id(emac->prueth, skb);
>> + ret = icssm_prueth_tx_enqueue(emac, skb, qid);
>> + if (ret) {
>> + if (ret != -ENOBUFS && netif_msg_tx_err(emac) &&
>> + net_ratelimit())
>> + netdev_err(ndev, "packet queue failed: %d\n", ret);
>> + goto fail_tx;
>> + }
>
>> + if (ret == -ENOBUFS) {
>> + ret = NETDEV_TX_BUSY;
>
>
> Something needs to stop the queue, right? Otherwise the stack will
> send the frame right back to the driver.
>
Yes, we will notify upper layer with “netif_tx_stop_queue()” when returning
“NETDEV_TX_BUSY” to not push again immediately.
>> +static inline void icssm_emac_finish_napi(struct prueth_emac *emac,
>> + struct napi_struct *napi,
>> + int irq)
>> +{
>> + napi_complete(napi);
>> + enable_irq(irq);
>
> This helper has a single caller, just put the two lines of code directly
> there. And use napi_complete_done(), please.
We will address this in the next version.
Thanks and Regards,
Parvathi.
More information about the linux-arm-kernel
mailing list