[PATCH v2 3/5] coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id
Jonathan Cameron
Jonathan.Cameron at huawei.com
Fri Jul 11 02:28:43 PDT 2025
On Tue, 8 Jul 2025 16:15:00 +0100
Alireza Sanaee <alireza.sanaee at huawei.com> wrote:
> Use the newly created API to grab CPU id.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee at huawei.com>
> ---
> .../hwtracing/coresight/coresight-cti-platform.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c
> index d0ae10bf6128..e1dc559d54aa 100644
> --- a/drivers/hwtracing/coresight/coresight-cti-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c
> @@ -41,20 +41,8 @@
> */
> static int of_cti_get_cpu_at_node(const struct device_node *node)
> {
> - int cpu;
> - struct device_node *dn;
> + int cpu = of_cpu_phandle_to_id(node, NULL, 0);
Could do a single line - kind of down to coresight maintainers preference though!
return (of_cpu_phandle_to_id(node, NULL, 0) < 0) ? -1; cpu;
+CC Suzuki (you got the two reviewers in the +CC but not the maintainer)
>
> - if (node == NULL)
> - return -1;
> -
> - dn = of_parse_phandle(node, "cpu", 0);
> - /* CTI affinity defaults to no cpu */
> - if (!dn)
> - return -1;
> - cpu = of_cpu_node_to_id(dn);
> - of_node_put(dn);
> -
> - /* No Affinity if no cpu nodes are found */
> return (cpu < 0) ? -1 : cpu;
> }
>
More information about the linux-arm-kernel
mailing list