[PATCH v2 08/12] pinctrl: qcom: use generic pin function helpers
Konrad Dybcio
konrad.dybcio at oss.qualcomm.com
Thu Jul 10 05:25:12 PDT 2025
On 7/9/25 4:39 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
>
> Use the existing infrastructure for storing and looking up pin functions
> in pinctrl core. Remove hand-crafted callbacks.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
> ---
[...]
> int msm_pinctrl_probe(struct platform_device *pdev,
> const struct msm_pinctrl_soc_data *soc_data)
> {
> + const struct pinfunction *func;
> struct msm_pinctrl *pctrl;
> struct resource *res;
> int ret;
> @@ -1606,6 +1581,14 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> return PTR_ERR(pctrl->pctrl);
> }
>
> + for (i = 0; i < soc_data->nfunctions; i++) {
> + func = &soc_data->functions[i];
> +
> + ret = pinmux_generic_add_pinfunction(pctrl->pctrl, func, NULL);
> + if (ret < 0)
> + return ret;
> + }
It's good in principle, but we're now going to house two copies of
the function data in memory... Can we trust __initconst nowadays?
Konrad
More information about the linux-arm-kernel
mailing list