[PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP

Taishi Shimizu s.taishi14142 at gmail.com
Thu Jul 10 01:49:08 PDT 2025


On Tue, Jul 8, 2025 at 10:34 AM Krzysztof Kozlowski <krzk at kernel.org> wrote:
> On Thu, Jun 26, 2025 at 12:43:15AM +0900, Taishi Shimizu wrote:
> > +	chosen {
> > +		bootargs = "console=ttyS0,115200";
>
> Please use stdout path property.

Thanks for the review. Since `stdout-path` is already defined in
`bcm4708.dtsi`, I removed the `chosen` node from the board DTS.

> +		leds {
> +			compatible = "gpio-leds";
> +
> > +		led-power0 {
> > +			label = "bcm53xx:white:power";
>
> You should use rather color and function properties.

I replaced all `label` properties in the LED definitions with `color` and
`function` properties as appropriate.

I'll send v2 accordingly. Thanks!

Best regards,  
Taishi Shimizu



More information about the linux-arm-kernel mailing list