[PATCH v3 2/5] remoteproc: imx_rproc: Add support for System Manager API

[Peng Fan]

> Subject: Re: [PATCH v3 2/5] remoteproc: imx_rproc: Add support for
> System Manager API
> 
...
> > >
> > >This is set all the time imx_rproc_prepare() is called - isn't there
> > >a way to set it once at initialisation time?
> >
> > Yeah. Moving this to probe path should be ok, such as in
> imx_rproc_detect_mode.
> > The drawback is M7 logical machine will be left in powered up state if
> > moving to probe path before user starts M7 LM. Leaving in here
> means
> > M7 logcal machine will be only powered up when user does "echo
> start >
> > /xx/remoteproc-y/state", but needs to set
> IMX_RPROC_FLAGS_SM_LMM_AVAIL
> > flags each time do preparing.
> >
> > If you prefer moving this logic to probe, I could give a try to move
> > to imx_rproc_detect_mode which is probe path.
> >
> > How do you think?
> 
> Just leave it where it is.

ok. I will just put this piece code in a separate function as you
commented in last reply and leave the function being invoked
in imx_rproc_prepare.

I will send out v4 with above change after test. It should
tomorrow.

Thanks,
Peng.