[PATCH 2/9] dt-bindings: fsl,fpga-qixis-i2c: extend support to also cover the LX2160ARDB FPGA
Krzysztof Kozlowski
krzk at kernel.org
Wed Jul 9 05:17:27 PDT 2025
On 09/07/2025 13:26, Ioana Ciornei wrote:
> Extend the list of supported compatible strings with fsl,lx2160ardb-fpga.
>
> Since the register map exposed by the LX2160ARDB's FPGA also contains
> two GPIO controllers, accept the necessary GPIO pattern property. At the
> same time, add the #address-cells and #size-cells properties as valid
> ones.
>
> This is needed because when defining child devices such as the GPIO
> controller described in the added example, the child device needs a the
> reg property to properly identify its register location.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com>
> ---
> .../bindings/board/fsl,fpga-qixis-i2c.yaml | 35 +++++++++++++++++++
So here is the board? Why FPGA is in the board...
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/board/fsl,fpga-qixis-i2c.yaml b/Documentation/devicetree/bindings/board/fsl,fpga-qixis-i2c.yaml
> index 28b37772fb65..e8981f974210 100644
> --- a/Documentation/devicetree/bindings/board/fsl,fpga-qixis-i2c.yaml
> +++ b/Documentation/devicetree/bindings/board/fsl,fpga-qixis-i2c.yaml
> @@ -22,6 +22,13 @@ properties:
> - fsl,lx2160aqds-fpga
> - const: fsl,fpga-qixis-i2c
> - const: simple-mfd
> + - const: fsl,lx2160ardb-fpga
Weird, your first patch added three compatibles, this adds only one.
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
>
> interrupts:
> maxItems: 1
> @@ -32,6 +39,10 @@ properties:
> mux-controller:
> $ref: /schemas/mux/reg-mux.yaml
>
> +patternProperties:
> + "^gpio(@[0-9a-f]+)?$":
Why unit address is optional? Anyway, this is wrong. You do not have
ranges here and earlier you already said children do not have any
addressing. Look at mux.
> + $ref: /schemas/gpio/fsl,fpga-gpio.yaml
> +
> required:
> - compatible
> - reg
> @@ -68,3 +79,27 @@ examples:
> };
> };
>
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + board-control at 66 {
> + compatible = "fsl,lx2160ardb-fpga";
> + reg = <0x66>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio at 19 {
And what is the meaning of @19?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list