[PATCH v2 05/12] iio: dac: Remove redundant pm_runtime_mark_last_busy() calls
Andy Shevchenko
andriy.shevchenko at intel.com
Wed Jul 9 01:48:04 PDT 2025
On Wed, Jul 09, 2025 at 02:11:52AM +0300, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
...
> - if (!enable) {
> - pm_runtime_mark_last_busy(dev);
> + if (!enable)
> pm_runtime_put_autosuspend(dev);
> - }
>
> return 0;
>
> err_put_pm:
> - if (enable) {
> - pm_runtime_mark_last_busy(dev);
> + if (enable)
> pm_runtime_put_autosuspend(dev);
> - }
>
> return ret;
Hmm... Why not simply
ret = 0;
err_put_pm:
if (enable)
pm_runtime_put_autosuspend(dev);
return ret;
instead of the duplication?
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list