[PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks

Andy Shevchenko andy.shevchenko at gmail.com
Wed Jul 9 01:32:40 PDT 2025


On Wed, Jul 9, 2025 at 9:42 AM Bartosz Golaszewski <brgl at bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.

...

>         if (value)
> -               regmap_set_bits(wg->regmap, reg, 1);
> -       else
> -               regmap_clear_bits(wg->regmap, reg, 1);
> +               return regmap_set_bits(wg->regmap, reg, 1);
> +
> +       return regmap_clear_bits(wg->regmap, reg, 1);

return regmap_assign_bits(...);

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy at kernel.org>

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list