[PATCH] firmware: arm_scmi: convert to SYSTEM_SLEEP_PM_OPS
Peng Fan
peng.fan at nxp.com
Wed Jul 9 00:04:49 PDT 2025
> Subject: [PATCH] firmware: arm_scmi: convert to
> SYSTEM_SLEEP_PM_OPS
>
> From: Arnd Bergmann <arnd at arndb.de>
>
> The old SET_SYSTEM_SLEEP_PM_OPS() macro leads to a warning about
> an unused function:
>
> drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error:
> 'scmi_system_power_resume' defined but not used [-Werror=unused-
> function]
> 363 | static int scmi_system_power_resume(struct device *dev)
>
> The proper way to do this these days is to use
> SYSTEM_SLEEP_PM_OPS() and pm_sleep_ptr().
>
> Fixes: 9a0658d3991e ("firmware: arm_scmi: power_control: Ensure
> SCMI_SYSPOWER_IDLE is set early during resume")
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Thanks for the fix. Nathan Chancellor posted a fix earlier, but
yours has pm_sleep_ptr which is better.
Acked-by: Peng Fan <peng.fan at nxp.com>
More information about the linux-arm-kernel
mailing list